Skip to content

Commit f9ae256

Browse files
committed
Prevent source directories from being harvested.
Fixes wixtoolset/issues#8096.
1 parent 289c93d commit f9ae256

File tree

4 files changed

+196
-207
lines changed

4 files changed

+196
-207
lines changed

src/internal/SetBuildNumber/Directory.Packages.props.pp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<PackageVersion Include="WixToolset.Dtf.CustomAction" Version="{packageversion}" />
66
<PackageVersion Include="WixToolset.Dtf.Resources" Version="{packageversion}" />
77
<PackageVersion Include="WixToolset.Dtf.WindowsInstaller" Version="{packageversion}" />
8+
<PackageVersion Include="WixToolset.Dtf.WindowsInstaller.Package" Version="{packageversion}" />
89

910
<PackageVersion Include="WixInternal.TestSupport" Version="{packageversion}" />
1011
<PackageVersion Include="WixInternal.TestSupport.Native" Version="{packageversion}" />

src/wix/WixToolset.Core/HarvestFilesCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ private void HarvestFiles(HarvestFilesSymbol harvestFile, IntermediateSection se
128128
private IEnumerable<WildcardFile> GetWildcardFiles(HarvestFilesSymbol harvestFile, IEnumerable<string> patterns)
129129
{
130130
var sourceLineNumbers = harvestFile.SourceLineNumbers;
131-
var sourcePath = harvestFile.SourcePath;
131+
var sourcePath = harvestFile.SourcePath?.TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
132132

133133
var files = new List<WildcardFile>();
134134

@@ -158,7 +158,7 @@ private IEnumerable<WildcardFile> GetWildcardFiles(HarvestFilesSymbol harvestFil
158158
else if (!Path.IsPathRooted(directoryPortion))
159159
{
160160
directoryPortion = Path.Combine(sourceDirectory, directoryPortion);
161-
recursiveDirOffset = sourceDirectory.Length + 1;
161+
recursiveDirOffset = directoryPortion.Length + 1;
162162
}
163163

164164
var foundFiles = Directory.EnumerateFiles(directoryPortion, filePortion, recursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);

0 commit comments

Comments
 (0)