Skip to content

Commit 4dcde24

Browse files
committed
Decompile Scope=perUserOrMachine.
Fixes wixtoolset/issues#9144
1 parent c1b3fba commit 4dcde24

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3051,10 +3051,18 @@ private void FinalizeSummaryInformationStream(TableIndexedCollection tables)
30513051
else
30523052
{
30533053
var xAllUsers = this.DecompilerHelper.RootElement.Elements(Names.PropertyElement).SingleOrDefault(p => p.Attribute("Id")?.Value == "ALLUSERS");
3054+
var xMsiInstallerPerUser = this.DecompilerHelper.RootElement.Elements(Names.PropertyElement).SingleOrDefault(p => p.Attribute("Id")?.Value == "MSIINSTALLPERUSER");
30543055
if (xAllUsers?.Attribute("Value")?.Value == "1")
30553056
{
30563057
xAllUsers?.Remove();
30573058
}
3059+
else if (xAllUsers?.Attribute("Value")?.Value == "2" && xMsiInstallerPerUser?.Attribute("Value")?.Value == "1")
3060+
{
3061+
this.DecompilerHelper.RootElement.SetAttributeValue("Scope", "perUserOrMachine");
3062+
3063+
xAllUsers?.Remove();
3064+
xMsiInstallerPerUser?.Remove();
3065+
}
30583066
}
30593067
}
30603068

src/wix/test/WixToolsetTest.CoreIntegration/TestData/DecompileNullComponent/Expected.wxs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
2-
<Package Codepage="65001" Language="1033" Manufacturer="Example Corporation" Name="MsiPackage" UpgradeCode="{047730A5-30FE-4A62-A520-DA9381B8226A}" Version="1.0.0.0" InstallerVersion="200" ProductCode="{6F9B5694-F0F1-437C-919B-0D2DAF2D9DEA}">
2+
<Package Codepage="65001" Language="1033" Manufacturer="Example Corporation" Name="MsiPackage" UpgradeCode="{047730A5-30FE-4A62-A520-DA9381B8226A}" Version="1.0.0.0" InstallerVersion="200" ProductCode="{6F9B5694-F0F1-437C-919B-0D2DAF2D9DEA}" Scope="perUserOrMachine">
33
<StandardDirectory Id="ProgramFilesFolder">
44
<Directory Id="INSTALLFOLDER" Name="MsiPackage" ShortName="oekcr5lq">
55
<Component Id="filcV1yrx0x8wJWj4qMzcH21jwkPko" Guid="" Bitness="always32">
Binary file not shown.

0 commit comments

Comments
 (0)