Skip to content

Conversation

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: 075468c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jun 6, 2024 11:49am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Jun 5, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 5, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr guides/components.mdx Localization changed, will be marked as complete.
fr guides/i18n.mdx Localization changed, will be marked as complete.
fr guides/sidebar.mdx Localization changed, will be marked as complete.
fr reference/configuration.mdx Localization changed, will be marked as complete.
fr reference/frontmatter.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @thomasbnt, LGTM ✅

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates 🙌

Left a few minor suggestions/questions but this is looking really great!

@thomasbnt
Copy link
Member Author

Hello and thanks both @dreyfus92 @HiDeoo for the review! I added your suggestions, thanks a lot!

Copy link
Contributor

@pioupia pioupia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast updates and everyone for the reviews, let's ship all this new content 🚀

@HiDeoo HiDeoo merged commit 0df299f into withastro:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants