Skip to content

Remove deprecated APIs #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 3, 2023
Merged

Remove deprecated APIs #5707

merged 6 commits into from
Jan 3, 2023

Conversation

@bluwy
Copy link
Member

@bluwy bluwy commented Dec 30, 2022

Changes

  • Remove Astro.resolve, Astro.fetchContent, and Astro.canonicalURL.
  • Remove buildConfig option parameter from integration astro:build:start hook

The changesets have more information.

Testing

Existing tests should pass (made some tweaks to the old APIs)

Docs

Needs a review of the changeset description.

@bluwy bluwy added the semver: major Change triggers a `major` release label Dec 30, 2022
@bluwy bluwy requested a review from a team as a code owner December 30, 2022 15:18
@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: b27537d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Dec 30, 2022
bholmesdev
bholmesdev reviewed Dec 30, 2022
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions before merging. Really deprappreciate this!

aFuzzyBear
aFuzzyBear reviewed Jan 2, 2023
View reviewed changes
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a sad PR this one, but needed, thank you for doing this @bluwy great bit of housekeeping 🧹

packages/astro/src/runtime/server/astro-global.ts
glob: createAstroGlobFn(),
// INVESTIGATE is there a use-case for multi args?
// TODO remove in 2.0
resolve(...segments: string[]) {
Copy link
Contributor

@aFuzzyBear aFuzzyBear Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah Astro.resolve I mind when you came in, and then boom it was used everywhere, prior to the shift to esm.
RIP

packages/astro/src/runtime/server/astro-global.ts
site,
site: site ? new URL(site) : undefined,
generator: `Astro v${ASTRO_VERSION}`,
fetchContent: createDeprecatedFetchContentFn(),
Copy link
Contributor

@aFuzzyBear aFuzzyBear Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astro.fetchContent another fan favorite, way before Astro.glob got better, this was the trick used on almost every Astro site <0.24.

RIP...

@aFuzzyBear
Copy link
Contributor

aFuzzyBear commented Jan 2, 2023

Could we look into the smoke test, Im not familiar with this part of the process, but having re-ran them its saying on the docs build an external dep is missing its exports 🤷‍♂️

@bholmesdev
Copy link
Contributor

bholmesdev commented Jan 2, 2023

@aFuzzyBear we just merged a fix! Needs a rebase and we're golden 🐻

delucis
delucis approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewp matthewp merged commit 5eba34f into main Jan 3, 2023
@matthewp matthewp deleted the remove-deprecated-options branch January 3, 2023 19:06
@astrobot-houston astrobot-houston mentioned this pull request Jan 3, 2023
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jul 29, 2024
@ArmandPhilippot
fix(api-reference): remove Astro.canonicalURL
3c7d574 
It was deprecated but it has been removed in v2.0.0 (see withastro/astro#5707). I
think it should not be displayed in the reference anymore since we are
now at v4.12.1
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jul 29, 2024
@ArmandPhilippot
fix(api-reference): remove Astro.canonicalURL
32554a2 
It was deprecated but it has been removed in v2.0.0 (see withastro/astro#5707). I
think it should not be displayed in the reference anymore since we are
now at v4.12.1
@ArmandPhilippot ArmandPhilippot mentioned this pull request Jul 29, 2024
Merged
ematipico pushed a commit that referenced this pull request Feb 5, 2025
@bluwy
Remove deprecated APIs (#5707)
b212d96 
* Remove deprecated Astro globals

* Remove deprecated hook param

* Fix test

* Add changeset

* Add TODO
ematipico pushed a commit that referenced this pull request Feb 5, 2025
@bluwy
Remove deprecated APIs (#5707)
fa10d88 
* Remove deprecated Astro globals

* Remove deprecated hook param

* Fix test

* Add changeset

* Add TODO
ematipico pushed a commit that referenced this pull request Feb 6, 2025
@bluwy
Remove deprecated APIs (#5707)
cd864f4 
* Remove deprecated Astro globals

* Remove deprecated hook param

* Fix test

* Add changeset

* Add TODO
ematipico pushed a commit that referenced this pull request Feb 6, 2025
@bluwy
Remove deprecated APIs (#5707)
af52c1d 
* Remove deprecated Astro globals

* Remove deprecated hook param

* Fix test

* Add changeset

* Add TODO
ematipico pushed a commit that referenced this pull request Feb 7, 2025
@bluwy
Remove deprecated APIs (#5707)
b43950e 
* Remove deprecated Astro globals

* Remove deprecated hook param

* Fix test

* Add changeset

* Add TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

+2 more reviewers

@aFuzzyBear aFuzzyBear aFuzzyBear left review comments

@bholmesdev bholmesdev bholmesdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) semver: major Change triggers a `major` release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bluwy @aFuzzyBear @bholmesdev @delucis @matthewp