Feat: Add custom exceptions [#19] #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisedev-pstach
requested changes
Aug 1, 2025
Contributor
There was a problem hiding this comment.
Looks good! Defo step in good direction, Can you double check other projects? I am sure that there are more opportunities to add good error handling, I think good candidate can be InferPage project (its the one that opens with mcli "infer" command)
And also Core project, Its mainly "projection" layer but it also lacks good error handling atm, For example, i think now it will even allow to create ChatContext without providing model, which does not make sense at all, similar perhaps for AgentContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.