This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Conversation
|
|
- Adding WindowsXamlHost to WinForms sample. - Refactoring WPF sample to put Xaml content in a single WindowsXamlHost instead of creating a host per control. - Removing WrappedRectangle and WrappedButton, which are not needed.
gegao18
force-pushed
the
gegao/SampleRefactor
branch
from
81ef4ae to
8ae623a
Compare
rjmurillo
approved these changes
Nov 26, 2018
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Toolkit.Forms.UI.Controls", "Microsoft.Toolkit.Forms.UI.Controls\Microsoft.Toolkit.Forms.UI.Controls.csproj", "{9B054ABA-B5B4-42F4-8E29-97DCCF79C726}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Toolkit.Sample.Forms.WebView", "Microsoft.Toolkit.Sample.Forms.WebView\Microsoft.Toolkit.Sample.Forms.WebView.csproj", "{D103E448-64B1-407C-B09E-7C61AF9F2740}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Toolkit.Sample.Forms.WebView", "Microsoft.Toolkit.Sample.Forms.WebView\Microsoft.Toolkit.Sample.Forms.WebView.csproj", "{D103E448-64B1-407C-B09E-7C61AF9F2740}" |
Contributor
There was a problem hiding this comment.
Why did the GUIDs need to change?
azchohfi
suggested changes
Dec 20, 2018
Contributor
azchohfi
left a comment
azchohfi
left a comment
There was a problem hiding this comment.
Project is not building.
Please run UpdateHeaders.bat or '.\build.ps1 -target=UpdateHeaders' and commit the changes.
azchohfi
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
PR Type
Sample app changes
What is the current behavior?
The sample wraps each individual Xaml control in its own WindowsXamlHost, which creates a DesktopWindowXamlSource under the covers
What is the new behavior?
Put all Xaml content in a single WindowsXamlHost instead of creating a host per control. This is a more efficient use of DesktopWindowXamlSource and should be the pattern we promote.
PR Checklist
Other information