This repository was archived by the owner on Aug 30, 2023. It is now read-only.
change logic of closing open popups on move/size#30
Merged
Conversation
|
|
gegao18
approved these changes
Jan 15, 2019
azchohfi
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #25 Xaml Island popups should not be closed when WPF/WinForms window is moved/sized
PR Type
What kind of change does this PR introduce?
< - Bugfix >
What is the current behavior?
<In WPF/WinForms hosting Xaml Islands scenarios, all open popups are closed whenever the host window is moved or resized. This logic is problematic. In some cases popups that should not be closed are getting closed (eg ContentDialog)>
What is the new behavior?
When host window is moved, all open popups will be re-positioned to follow the new position of the host window. No action is taken when the host window is resized anymore.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information