Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Adding the Max Version ID to the sample app Manifest to avoid exceptions#14

Merged
azchohfi merged 1 commit intomasterfrom
miguelrb
Dec 29, 2018
Merged

Adding the Max Version ID to the sample app Manifest to avoid exceptions#14
azchohfi merged 1 commit intomasterfrom
miguelrb

Conversation

@marb2000
Copy link
Contributor

Adding the Max Version ID to the apps' Manifest to make the tests run in future builds of Windows

Issue: #
In the latest insider Windows 10 builds, the app throws an exception because the MaxVersion wasn't set up.

PR Type

What kind of change does this PR introduce?

  • Sample app changes

What is the current behavior?

If you run the app in an insider builds, the test apps crash.

What is the new behavior?

The app is no longer crashing.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@marb2000 marb2000 added the bug 🐛 Something isn't working label Dec 19, 2018
@dnfclas
Copy link

dnfclas commented Dec 19, 2018

CLA assistant check
All CLA requirements met.

@marb2000 marb2000 requested a review from nmetulev December 19, 2018 01:35
@azchohfi azchohfi merged commit c32a88b into master Dec 29, 2018
@delete-merged-branch delete-merged-branch bot deleted the miguelrb branch December 29, 2018 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants