This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Refactor Win32 tools for use in native projects#138
Merged
michael-hawker merged 5 commits intomasterfrom Aug 7, 2019
Merged
Conversation
azchohfi
reviewed
Jul 8, 2019
Microsoft.Toolkit.Win32.UI.Tools/Microsoft.Toolkit.Win32.UI.Tools.csproj
Show resolved
Hide resolved
azchohfi
approved these changes
Aug 6, 2019
| <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net462;netcoreapp3.0</TargetFrameworks> | ||
| <RootNamespace>Microsoft.Toolkit.Win32.SDK.Tasks</RootNamespace> |
Contributor
There was a problem hiding this comment.
This is not used, but it should match the PackageId or the Assembly name.
michael-hawker
approved these changes
Aug 7, 2019
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Tested swapping out packages for Miguel's sample, worked fine still.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the tools use it to generate manifests and perform layout for Win32 apps using XamlIslands is shipping in a manage only package.
This make it impossible for native projects (e.g.: Windows Terminal) to use.
What is the new behavior?
We created a separate NuGet package and make XamlHost reference the "tools" package.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information