This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Conversation
azchohfi
suggested changes
Apr 9, 2019
azchohfi
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Workaround Bug 19653836: Remove code that sets the CoreWindow as a child of the first top-level HWND, and other cruft from the DWXS CCI implementation
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a secondary window is closed in a multi window app that it itself created the first WindowsXamlHost instance, and if the instance of the xaml hosting element is not disposed, then Xaml will be left in a bad state using a dangling HWND pointer.
When a new Window is created after this, some Xaml elements will not render correctly anymore.
What is the new behavior?
To workaround this issue, we are calling Dispose in response to the parent handle of getting destroyed.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information