Replace local highest_finalized_slot with pool.highest_finalized_slot. (anza-xyz#325)

Author: wen-coding

votor/src/certificate_pool_service.rs

@@ -89,15 +89,12 @@ impl CertificatePoolService {
         new_finalized_slot: Option<Slot>,
         new_certificates_to_send: Vec<Arc<CertificateMessage>>,
         current_root: &mut Slot,
-        highest_finalized_slot: &mut Slot,
         standstill_timer: &mut Instant,
         stats: &mut CertificatePoolServiceStats,
     ) -> Result<(), AddVoteError> {
         // If we have a new finalized slot, update the root and send new certificates
-        if let Some(new_finalized_slot) = new_finalized_slot {
+        if new_finalized_slot.is_some() {
             // Reset standstill timer
-            debug_assert!(new_finalized_slot > *highest_finalized_slot);
-            *highest_finalized_slot = new_finalized_slot;
             *standstill_timer = Instant::now();
             CertificatePoolServiceStats::incr_u16(&mut stats.new_finalized_slot);
             // Set root
@@ -145,7 +142,6 @@ impl CertificatePoolService {
         cert_pool: &mut CertificatePool,
         events: &mut Vec<VotorEvent>,
         current_root: &mut Slot,
-        highest_finalized_slot: &mut Slot,
         standstill_timer: &mut Instant,
         stats: &mut CertificatePoolServiceStats,
     ) -> Result<(), AddVoteError> {
@@ -173,7 +169,6 @@ impl CertificatePoolService {
                     new_finalized_slot,
                     new_certificates_to_send,
                     current_root,
-                    highest_finalized_slot,
                     standstill_timer,
                     stats,
                 )?;
@@ -211,7 +206,6 @@ impl CertificatePoolService {
 
         // Standstill tracking
         let mut standstill_timer = Instant::now();
-        let mut highest_finalized_slot = cert_pool.highest_finalized_slot();
 
         // Kick off parent ready
         let root_bank = ctx.root_bank_cache.root_bank();
@@ -234,7 +228,7 @@ impl CertificatePoolService {
             );
 
             if standstill_timer.elapsed() > STANDSTILL_TIMEOUT {
-                events.push(VotorEvent::Standstill(highest_finalized_slot));
+                events.push(VotorEvent::Standstill(cert_pool.highest_finalized_slot()));
                 stats.standstill = true;
                 standstill_timer = Instant::now();
                 if Err(AddVoteError::VotingServiceSenderDisconnected)
@@ -281,7 +275,6 @@ impl CertificatePoolService {
                     &mut cert_pool,
                     &mut events,
                     &mut current_root,
-                    &mut highest_finalized_slot,
                     &mut standstill_timer,
                     &mut stats,
                 ) {