-
-
Notifications
You must be signed in to change notification settings - Fork 60
feat: Browser profile configuration UI rehaul #2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SuaYoo
wants to merge
26
commits into
frontend-browser-profile-ui-enhancements
Choose a base branch
from
frontend-browser-profile-ui-enhancements--detail-page
base: frontend-browser-profile-ui-enhancements
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Browser profile configuration UI rehaul #2972
SuaYoo
wants to merge
26
commits into
frontend-browser-profile-ui-enhancements
from
frontend-browser-profile-ui-enhancements--detail-page
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57c369e to
77beece
Compare
6f9ee72 to
d5a23cb
Compare
4e93665 to
39f5589
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2958
Resolves #2960
WIP for #2962
Changes
This change is a rewrite of the browser profile detail page UI to support a consistent UX flow for creating and configuring profiles.
Additional features:
Manual testing
Screenshots