Fix Workspace Circular Symlink (#1319)

Author: mattietea

packages/knip/fixtures/workspaces-circular-symlinks/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@fixtures/workspaces-symlinks",
+  "workspaces": [
+    "packages/*"
+  ]
+}

packages/knip/fixtures/workspaces-circular-symlinks/packages/lib-a/index.ts

@@ -0,0 +1 @@
+export const libA = 'lib-a';

packages/knip/fixtures/workspaces-circular-symlinks/packages/lib-a/node_modules/@fixtures/lib-b

@@ -0,0 +1,8 @@
+{
+  "name": "@fixtures/lib-a",
+  "version": "1.0.0",
+  "main": "./index.ts",
+  "exports": {
+    ".": "./index.ts"
+  }
+}

packages/knip/fixtures/workspaces-circular-symlinks/packages/lib-a/package.json

@@ -0,0 +1 @@
+export const libB = 'lib-b';

packages/knip/fixtures/workspaces-circular-symlinks/packages/lib-b/index.ts

@@ -0,0 +1,8 @@
+{
+  "name": "@fixtures/lib-b",
+  "version": "1.0.0",
+  "main": "./index.ts",
+  "exports": {
+    ".": "./index.ts"
+  }
+}

packages/knip/fixtures/workspaces-circular-symlinks/packages/lib-b/node_modules/@fixtures/lib-a

@@ -54,7 +54,8 @@ const defaultGlob = async ({ cwd, dir = cwd, patterns, gitignore = true, label }
   });
 };
 
-const syncGlob = ({ cwd, patterns }: { cwd?: string; patterns: string | string[] }) => fg.sync(patterns, { cwd });
+const syncGlob = ({ cwd, patterns }: { cwd?: string; patterns: string | string[] }) =>
+  fg.sync(patterns, { cwd, followSymbolicLinks: false });
 
 const firstGlob = async ({ cwd, patterns }: GlobOptions) => {
   const stream = fg.globStream(patterns.map(removeProductionSuffix), { cwd, ignore: GLOBAL_IGNORE_PATTERNS });

packages/knip/fixtures/workspaces-circular-symlinks/packages/lib-b/package.json

@@ -0,0 +1,18 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { _syncGlob } from '../src/util/glob.js';
+import { main } from '../src/index.js';
+import { createOptions } from '../src/util/create-options.js';
+import baseCounters from './helpers/baseCounters.js';
+import { resolve } from './helpers/resolve.js';
+
+const cwd = resolve('fixtures/workspaces-circular-symlinks');
+
+test('syncGlob should not traverse circular symlinks', () => {
+  const libACwd = resolve('fixtures/workspaces-circular-symlinks/packages/lib-a');
+  const files = _syncGlob({ patterns: ['./**/*.ts'], cwd: libACwd });
+
+  const expected = 1;
+  assert.equal(files.length, expected, `Expected ${expected} file but found ${files.length}`);
+  assert.equal(files[0], 'index.ts');
+});