Skip to content

Commit 8849bf4

Browse files
authored
Reflect recent changes in webfactory/html5-tagrewriter (#3)
1 parent c379678 commit 8849bf4

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

src/Twig/Extension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ public function rewriteTags(string $html, ?string $name = null): string
5252
throw new RuntimeException('No TagRewriter registered.');
5353
}
5454

55-
return $tagRewriter->processFragment($html);
55+
return $tagRewriter->processBodyFragment($html);
5656
}
5757
}

tests/Fixtures/Handler/TestDefaultHandler.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Webfactory\Html5TagRewriterBundle\Tests\Fixtures\Handler;
44

55
use Dom\Element;
6+
use Dom\Node;
67
use Webfactory\Html5TagRewriter\Handler\BaseRewriteHandler;
78
use Webfactory\Html5TagRewriterBundle\Attribute\AsRewriteHandler;
89

@@ -14,8 +15,9 @@ public function appliesTo(): string
1415
return '//html:p';
1516
}
1617

17-
public function match(Element $element): void
18+
public function match(Node $node): void
1819
{
19-
$element->textContent = 'test-default-handler';
20+
\assert($node instanceof Element);
21+
$node->textContent = 'test-default-handler';
2022
}
2123
}

tests/Fixtures/Handler/TestSpecialHandler.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Webfactory\Html5TagRewriterBundle\Tests\Fixtures\Handler;
44

55
use Dom\Element;
6+
use Dom\Node;
67
use Webfactory\Html5TagRewriter\Handler\BaseRewriteHandler;
78

89
class TestSpecialHandler extends BaseRewriteHandler
@@ -17,8 +18,9 @@ public function appliesTo(): string
1718
return '//html:p';
1819
}
1920

20-
public function match(Element $element): void
21+
public function match(Node $node): void
2122
{
22-
$element->textContent = $this->content;
23+
\assert($node instanceof Element);
24+
$node->textContent = $this->content;
2325
}
2426
}

tests/Twig/ExtensionTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ protected function setUp(): void
2626

2727
public function testFilterUsesDefaultRewriter(): void
2828
{
29-
$this->tagRewriter->method('processFragment')
29+
$this->tagRewriter->method('processBodyFragment')
3030
->with('<p>input</p>')
3131
->willReturn('<p class="processed">output</p>');
3232

@@ -37,7 +37,7 @@ public function testFilterUsesDefaultRewriter(): void
3737

3838
public function testFilterUsesNamedRewriter(): void
3939
{
40-
$this->tagRewriter->method('processFragment')
40+
$this->tagRewriter->method('processBodyFragment')
4141
->with('<p>input</p>')
4242
->willReturn('<p class="processed">output</p>');
4343

@@ -49,9 +49,9 @@ public function testFilterUsesNamedRewriter(): void
4949
public function testFilterUsesOnlyDefaultRewriter(): void
5050
{
5151
$defaultRewriter = $this->createStub(TagRewriter::class);
52-
$defaultRewriter->method('processFragment')->with('something')->willReturn('default');
52+
$defaultRewriter->method('processBodyFragment')->with('something')->willReturn('default');
5353
$otherRewriter = $this->createStub(TagRewriter::class);
54-
$otherRewriter->method('processFragment')->willReturn('other');
54+
$otherRewriter->method('processBodyFragment')->willReturn('other');
5555

5656
$this->extension->setDefaultTagRewriter($defaultRewriter);
5757
$this->extension->addTagRewriter('other-rewriter', $otherRewriter);
@@ -62,9 +62,9 @@ public function testFilterUsesOnlyDefaultRewriter(): void
6262
public function testFilterUsesOnlySpecialRewriter(): void
6363
{
6464
$defaultRewriter = $this->createStub(TagRewriter::class);
65-
$defaultRewriter->method('processFragment')->willReturn('default');
65+
$defaultRewriter->method('processBodyFragment')->willReturn('default');
6666
$otherRewriter = $this->createStub(TagRewriter::class);
67-
$otherRewriter->method('processFragment')->with('something')->willReturn('other');
67+
$otherRewriter->method('processBodyFragment')->with('something')->willReturn('other');
6868

6969
$this->extension->setDefaultTagRewriter($defaultRewriter);
7070
$this->extension->addTagRewriter('other-rewriter', $otherRewriter);

0 commit comments

Comments
 (0)