-
-
Notifications
You must be signed in to change notification settings - Fork 60
fix(typings): ensure WDIO methods return Promise #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typings): ensure WDIO methods return Promise #1888
Conversation
|
|
|
It seems like the tests are failing and it seems it is related to this change. |
|
@christian-bromann Im having a look 👍🏼 |
See comments in this PR #962 (comment)
|
@christian-bromann I think I found a more elegant solution that does not affect jasmine. I will rebase for clean git history, I see the tests passing as well. |
The PR is ready for review now 👌 |
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
Released as 3.7.0 |
|
@christian-bromann I want to point out a slight problem with the I believe |
|
Im going to add that my changes introduce unwanted side effects :/ It looks like non WDIO matchers also get the |
This is almost the same change as #962, but against the
v3. This will ensure older versions of the framework still get the correctasyncmatchers signature. This is inline with how thev3branch is documented withtoBeDisplayedgettingawaited.expect-webdriverio/README.md
Lines 40 to 58 in dc1f48d
Some more context, in our projects people are sometimes forgetting to
awaitPromises, this typings change together with the eslint ruleno-floating-promiseswill allow us to highlight these bugs earlier in the development process.For more context, see the back and forth comments starting here