Skip to content

chore(tsc+lint): Enhancing project tsc and linting #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

chore(tsc+lint): Enhancing project tsc and linting #1867

merged 3 commits into from
Jun 23, 2025

Conversation

@dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented Jun 23, 2025 •
edited
Loading

  • Add linting on types for better code uniformity
  • Now also building tests since broken codes was missed. Some are fixed now, others that were more complicated were commented with ts-ignore TODO fix me
  • No real code changes to guarantee no breaking

@dprevost-LMI
Enhancing project tsc and linting
ded0bda 
- Add linting on types for better code uniformity
- Add tsc uncovering existing errors fixed now or skipped for later
@dprevost-LMI dprevost-LMI marked this pull request as ready for review June 23, 2025 16:47
erwinheitzman
erwinheitzman reviewed Jun 23, 2025
View reviewed changes
christian-bromann
christian-bromann approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 77af39a into webdriverio:main Jun 23, 2025
6 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Jun 23, 2025

Hey dprevost-LMI 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

christian-bromann added a commit that referenced this pull request Jun 24, 2025
@christian-bromann
Revert "chore(tsc+lint): Enhancing project tsc and linting (#1867)"
4b9bedb 
This reverts commit 77af39a.
@christian-bromann
Copy link
Member

christian-bromann commented Jun 24, 2025

@dprevost-LMI I had to revert this change due to #1870

@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Jun 24, 2025

No problem. If you accept, using the command below will keep the goodies and ensure no impact on the build process. However, initially, this command duplication had not been accepted, though.

    "compile": "tsc --build tsconfig.build.json",
    "tsc": "tsc --project tsconfig.json",

Unless the problem was the ignore '**/*/dist' in the eslint config, which would be surprising.
Btw, sorry for that impact!

@christian-bromann
Copy link
Member

christian-bromann commented Jun 24, 2025

No worries. Let's re-raise the original PR and include changes needed to fix the bug.

dprevost-LMI added a commit to dprevost-LMI/expect-webdriverio that referenced this pull request Jun 24, 2025
@dprevost-LMI
Reapply "chore(tsc+lint): Enhancing project tsc and linting (webdrive…
d6da535 
…rio#1867)"

This reverts commit 4b9bedb.
@dprevost-LMI dprevost-LMI mentioned this pull request Jun 24, 2025
Merged
@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Jun 24, 2025

Take 2: #1873

christian-bromann pushed a commit that referenced this pull request Jun 25, 2025
@dprevost-LMI
chore(tsc+lint): Enhancing project tsc and linting (#1873)
0f7d043 
* Reapply "chore(tsc+lint): Enhancing project tsc and linting (#1867)"

This reverts commit 4b9bedb.

* Separate build vs normal tsc check since it broke the release

* Add warning to be verbose on the exclude behavior

* Ensure no test folder in the lib folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

@erwinheitzman erwinheitzman Awaiting requested review from erwinheitzman

Assignees

No one assigned

Labels

Expensable $35 💸

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprevost-LMI @wdio-bot @christian-bromann @erwinheitzman