diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6a47f75b24d..6eb509a4a15 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,7 +15,7 @@ Fixes #(issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) -## Checklist: +## Checklist for 1.x: - [ ] I have selected the correct base branch. - [ ] I have performed a self-review of my own code. @@ -30,3 +30,21 @@ Fixes #(issue) - [ ] I have tested my code on the live network. - [ ] I have checked the Deploy Preview and it looks correct. - [ ] I have updated the `CHANGELOG.md` file in the root folder. + +## Checklist for 4.x: + +- [ ] I have selected the correct 4.x base branch. +- [ ] Within the description, the feature or issue is discussed in detail or an issue is linked. +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas. +- [ ] I have added any required tests for the changes I made +- [ ] I have made corresponding changes to the documentation +- [ ] Any dependent changes have been merged and published in downstream modules. +- [ ] I ran `yarn` successfully +- [ ] I ran `yarn lint` successfully +- [ ] I ran `yarn build:web` successfully +- [ ] I ran `yarn test:unit` successfully +- [ ] I ran `yarn test:integration` successfully +- [ ] I ran `compile:contracts` successfully +- [ ] I have tested my code. +- [ ] I have updated the corresponding `CHANGELOG.md` file in the packages I have edited.