This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Incompatible return types for 4.x implementations #5205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nikoulai
requested review from
avkos,
jdevcs,
luu-alex,
nazarhussain and
spacesailor24
jdevcs
suggested changes
Jul 6, 2022
nazarhussain
approved these changes
Jul 7, 2022
Contributor
nazarhussain
left a comment
nazarhussain
left a comment
There was a problem hiding this comment.
Apart from @jdevcs comments, looks good to me.
jdevcs
approved these changes
Jul 7, 2022
nikoulai
deleted the
5126/incompatible-return-types-for-4.x-implementations
branch
spacesailor24
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Throw error for not found tx in getTransaction * Fix failing tests * Move mock values to fixtures * Throw error for not found tx in getTransactionReceipt * Create dedicated error * Create dedicated error code
spacesailor24
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Throw error for not found tx in getTransaction * Fix failing tests * Move mock values to fixtures * Throw error for not found tx in getTransactionReceipt * Create dedicated error * Create dedicated error code
spacesailor24
added a commit
that referenced
this pull request
Jul 13, 2022
* Init web3_eth_migration_guide * WIP migration guide * WIP migration guide * Add more methods * WIP migration guide * Add request accounts * Apply some changes from reviews * Add getHashrate as deprecated * Remove getAccounts, as it will be fixed * Fix hex string to bigint in docs * Migration guide refactors * fix decode function. migration guide. fix unit tests (#5210) * fix decode function. migration guide. fix unit tests * 🏷️ Fix the contract types (#5213) * fix contract integration tests * add to changelog.md Co-authored-by: Nazar Hussain <[email protected]> * Incompatible return types for 4.x implementations (#5205) * Throw error for not found tx in getTransaction * Fix failing tests * Move mock values to fixtures * Throw error for not found tx in getTransactionReceipt * Create dedicated error * Create dedicated error code * Upgrade ethereum-cryptography to 1.0 (#5211) * ⬆️ Update ethereum-cryptography package * Apply suggestions from code review Co-authored-by: Junaid <[email protected]> * 🎨 Update the code as per feedback Co-authored-by: Junaid <[email protected]> * add net to web3 eth interface (#5217) * web3-common/core defaults documentation (#5198) * Init commit with defaultAccount * Add some more properties * Add more properties * Refactor docs * Apply some changes from reviews * Upgrade ethereum-cryptography to 1.0 (#5211) * ⬆️ Update ethereum-cryptography package * Apply suggestions from code review Co-authored-by: Junaid <[email protected]> * 🎨 Update the code as per feedback Co-authored-by: Junaid <[email protected]> * web3-common/core defaults documentation (#5198) * Init commit with defaultAccount * Add some more properties * Add more properties * Refactor docs * Apply some changes from reviews Co-authored-by: Nikos Iliakis <[email protected]> Co-authored-by: Nikos Iliakis <[email protected]> Co-authored-by: Junaid <[email protected]> Co-authored-by: Oleksii Kosynskyi <[email protected]> Co-authored-by: Nazar Hussain <[email protected]>
Muhammad-Altabba
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Init web3_eth_migration_guide * WIP migration guide * WIP migration guide * Add more methods * WIP migration guide * Add request accounts * Apply some changes from reviews * Add getHashrate as deprecated * Remove getAccounts, as it will be fixed * Fix hex string to bigint in docs * Migration guide refactors * fix decode function. migration guide. fix unit tests (#5210) * fix decode function. migration guide. fix unit tests * 🏷️ Fix the contract types (#5213) * fix contract integration tests * add to changelog.md Co-authored-by: Nazar Hussain <[email protected]> * Incompatible return types for 4.x implementations (#5205) * Throw error for not found tx in getTransaction * Fix failing tests * Move mock values to fixtures * Throw error for not found tx in getTransactionReceipt * Create dedicated error * Create dedicated error code * Upgrade ethereum-cryptography to 1.0 (#5211) * ⬆️ Update ethereum-cryptography package * Apply suggestions from code review Co-authored-by: Junaid <[email protected]> * 🎨 Update the code as per feedback Co-authored-by: Junaid <[email protected]> * add net to web3 eth interface (#5217) * web3-common/core defaults documentation (#5198) * Init commit with defaultAccount * Add some more properties * Add more properties * Refactor docs * Apply some changes from reviews * Upgrade ethereum-cryptography to 1.0 (#5211) * ⬆️ Update ethereum-cryptography package * Apply suggestions from code review Co-authored-by: Junaid <[email protected]> * 🎨 Update the code as per feedback Co-authored-by: Junaid <[email protected]> * web3-common/core defaults documentation (#5198) * Init commit with defaultAccount * Add some more properties * Add more properties * Refactor docs * Apply some changes from reviews Co-authored-by: Nikos Iliakis <[email protected]> Co-authored-by: Nikos Iliakis <[email protected]> Co-authored-by: Junaid <[email protected]> Co-authored-by: Oleksii Kosynskyi <[email protected]> Co-authored-by: Nazar Hussain <[email protected]> Signed-off-by: Muhammad-Altabba <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5126