diff --git a/CHANGELOG.md b/CHANGELOG.md index cbcd4be7472..8fff079535b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -533,4 +533,4 @@ Released with 1.0.0-beta.37 code base. ### Fixed - Fix jsonrpc payload and response types (#4743) (#4761) - +- Allowed more flexibility in typing the overly constrained `provider.disconnect` function (#4833) diff --git a/CONTRIBUTIONS.md b/CONTRIBUTIONS.md index 048fdb5918d..11727cb32a9 100644 --- a/CONTRIBUTIONS.md +++ b/CONTRIBUTIONS.md @@ -48,4 +48,5 @@ Emergency releases are allowed to shorten waiting periods depending on the sever There is precedent set for this in the 1.2.6 release (see [#3351](https://github.com/ethereum/web3.js/pull/3351)), where the consensus view was to make the smallest change necessary to address the emergency while waiving the `rc` process (meaning many existing additions to master were excluded). -This topic is under further org-wide discussion at [ethereum/js-organization#6](https://github.com/ethereum/js-organization/issues/6). +This topic was under further org-wide discussion [here](https://github.com/ethereum/js-organization/issues/6) +and [here](https://github.com/ChainSafe/web3.js/issues/3358). diff --git a/packages/web3-core-helpers/types/index.d.ts b/packages/web3-core-helpers/types/index.d.ts index e3ee7650f0a..be1e7556685 100644 --- a/packages/web3-core-helpers/types/index.d.ts +++ b/packages/web3-core-helpers/types/index.d.ts @@ -117,7 +117,7 @@ export class WebsocketProviderBase { reset(): void; - disconnect(code: number, reason: string): void; + disconnect(code?: number, reason?: string): void; connect(): void;