Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit 69c0b1a

Browse files
Spacesai1orwbt
andauthored
Solve Merge Conflicts for #4939 (#4987)
* Use && instead of ; to join composite commands * npm i rimraf --save-dev * Change command to run rimraf * npm i * Cut redundant command covered in test:cov * Split checklist item into 2 * Use 'have' for grammatical consistency * Add bash keyword before script source * Add line to changelog with PR # * Ran npm i * npm i Co-authored-by: WBT <WBT@users.noreply.github.com>
1 parent 63b3cfc commit 69c0b1a

4 files changed

Lines changed: 27391 additions & 403 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ Fixes #(issue)
2424
- [ ] My changes generate no new warnings.
2525
- [ ] Any dependent changes have been merged and published in downstream modules.
2626
- [ ] I ran `npm run dtslint` with success and extended the tests and types if necessary.
27-
- [ ] I ran `npm run test:unit` with success.
2827
- [ ] I ran `npm run test:cov` and my test cases cover all the lines and branches of the added code.
29-
- [ ] I ran `npm run build` and tested `dist/web3.min.js` in a browser.
28+
- [ ] I ran `npm run build` with success.
29+
- [ ] I have tested the built `dist/web3.min.js` in a browser.
3030
- [ ] I have tested my code on the live network.
3131
- [ ] I have checked the Deploy Preview and it looks correct.
3232
- [ ] I have updated the `CHANGELOG.md` file in the root folder.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ Released with 1.0.0-beta.37 code base.
539539
- fixed build issues of 1.7.2
540540

541541
## [Unreleased]
542+
- Improve npm script commands for development purposes (#4848)
542543

543544
## [1.7.4]
544545

0 commit comments

Comments
 (0)