Merge pull request #1 from ethereum/1.0

get fork in sync with local fork

Author: joshstevens19

.eslintignore

@@ -9,3 +9,5 @@ jest.config.js
 jest.preprocessor.js
 W3cWebsocket.js
 packages/**/rollup.config.js
+packages/**/node_modules
+angular-patch.js

.gitignore

@@ -15,3 +15,4 @@ node_modules
 coverage/
 lerna-debug.log
 .eslintcache
+docs/_build

.travis.yml

@@ -1,11 +1,9 @@
 language: node_js
 node_js:
-    - "6"
-    - "7"
     - "8"
-    - "9"
     - "10"
     - "11"
+    - "12"
 env:
     - CXX=g++-4.8
 addons:
@@ -14,10 +12,8 @@ addons:
     - ubuntu-toolchain-r-test
     packages:
     - g++-4.8
-env:
-  matrix:
-    - CXX=g++-4.8 TEST_SUITE=test
 before_script:
+    - npm i -g typescript@next
     - export DISPLAY=:99.0
     - sh -e /etc/init.d/xvfb start
 install:

ISSUE_TEMPLATE.md

@@ -1,24 +1,66 @@
-<!---
+<!---------------------------------------------------------------------------------------
 
-Steps before creating an issue: 
+Welcome to the Web3.js Issue Template!
 
-1. I have read the documentation.
-2. I was looking for an solution on stackoverflow or somewhere else.
-3. I checked the issue list if an identical issue already exists.
+If you're new around here, reading this will make sure you're helped ASAP.
+The more details you include, the better the community will be able to help you!
+
+---------------------------------------------------------------------------------------->
+
+### Description <!-- In plain words, what happened -->
 
--->
 
 #### Expected behavior
+<!---------------------------------------------------------------------
+    Example:
+    Calling `await web3.eth.getAccounts()` should return an array.
+----------------------------------------------------------------------->
+
 
 #### Actual behavior
+<!---------------------------------------------------------------------
+    Example:
+    Calling `await web3.eth.getAccounts()` returns "monkey".
+----------------------------------------------------------------------->
+
 
 #### Steps to reproduce the behavior
+<!---------------------------------------------------------------------
+    Example:
+    1. Import `web3`
+    2. Set the provider to `localhost`
+    3. Fetch latest block
+
+    Please use the code blocks Markdown does provide:
+
+    ```js
+      
+        console.log('Pretty syntax!');
+    
+    ```
+----------------------------------------------------------------------->
+
+
+#### Error Logs 
+
+
+#### Gists
+<!---------------------------------------------------------------------
+    Including links to gists with:
+    * ABI JSON,
+    * working Solidity code, etc.
+
+    gist tutorial: https://help.github.com/en/articles/creating-gists
+----------------------------------------------------------------------->
+
 
-1. [First step]
-2. [Second step]
-3. [and so on...]
+### Versions 
+* web3.js:
+* nodejs:
+* browser:
+* ethereum node:
 
-#### Error Logs
 
-#### Versions
-[NPM, Node, Web3.js, OS, device...]
+<!---------------------------------------------------------------------
+                    Thanks for your cooperation!
+----------------------------------------------------------------------->

PULL_REQUEST_TEMPLATE.md

@@ -13,7 +13,8 @@ Fixes #(issue)
 
 - [ ] Bug fix 
 - [ ] New feature 
-- [ ] Breaking change 
+- [ ] Breaking change
+- [ ] Enhancement
 
 ## Checklist:
 
@@ -27,4 +28,4 @@ Fixes #(issue)
 - [ ] I ran ```npm run test``` in the root folder with success and extended the tests if necessary.
 - [ ] I ran ```npm run build``` in the root folder and tested it in the browser and with node.
 - [ ] I ran ```npm run dtslint``` in the root folder and tested that all my types are correct
-- [ ] I have tested my code on the live network.
+- [ ] I have tested my code on an ethereum test network.

README.md

@@ -27,6 +27,12 @@ npm install web3
 yarn add web3
 ```
 
+### Meteor
+
+```bash
+meteor npm install --save [email protected]
+```
+
 ## Usage
 
 ```js
@@ -59,7 +65,7 @@ web3.eth.getAccounts()
 
 ### Usage with TypeScript
 
-We do support types within the repo itself. Please open an issue here if you find any wrong types.
+We support types within the repo itself. Please open an issue here if you find any wrong types.
 
 You can use `web3.js` as follows:
 
@@ -68,6 +74,15 @@ import Web3 from 'web3';
 const web3 = new Web3("ws://localhost:8546");
 ```
 
+If you are using the types in a `commonjs` module like for example a node app you just have to enable `esModuleInterop` in your `tsconfig` compile option, also enable `allowSyntheticDefaultImports` for typesystem compatibility:
+
+```js
+"compilerOptions": {
+    "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true,
+    ....
+```
+
 ## Documentation
 
 Documentation can be found at [read the docs][docs]
@@ -84,18 +99,19 @@ Documentation can be found at [read the docs][docs]
 
 ### Commands
 ```bash
-npm run clean // removes all the node_modules folders in all modules
-npm run bootstrap // install all dependencies and symlinks the internal modules for all modules
-npm run test // runs all tests 
-npm run build // runs rollup
-npm run dev // runs rollup with a watcher
+npm install # install all dependencies for npm run bootstrap
+npm run bootstrap # install all dependencies and symlinks the internal modules for all modules
+npm run build # runs rollup
+npm run test # runs all tests 
+npm run clean # removes all the node_modules folders in all modules
+npm run dev # runs rollup with a watcher
 
 ```
 
 ### Support
 
 ![browsers](https://img.shields.io/badge/browsers-latest%202%20versions-brightgreen.svg)
-![node](https://img.shields.io/badge/node->=6-green.svg)
+![node](https://img.shields.io/badge/node->=8-green.svg)
 
 ### Community
  - [Gitter](https://gitter.im/ethereum/web3.js?source=orgpage)