Skip to content

Conversation

@SoonIter
Copy link
Member

@SoonIter SoonIter commented Sep 19, 2025

Summary

fix(theme): llms component should not be included in rp-doc

image

Related Issue

introduced in (#2579) (#2600)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 19, 2025 07:46
@netlify
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 42b33bb
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/68cd0a6a1f4cd5000863b2cb
😎 Deploy Preview https://deploy-preview-2614--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where LLMS (Language Learning Model) components were inadvertently being styled by document-specific CSS rules. The fix involves modifying the CSS selector to be more specific and adding exclusion classes to LLMS components.

  • Updates CSS selector to only target links with rp-link class instead of all anchor tags
  • Adds rp-not-doc class to LLMS components to exclude them from document styling
  • Prevents unintended styling conflicts between document styles and LLMS plugin components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/theme-default/src/styles/doc.scss Updates link selector to be more specific and avoid styling all anchor tags
packages/plugin-llms/src/runtime/LlmsViewOptions.tsx Adds exclusion class to dropdown button component
packages/plugin-llms/src/runtime/LlmsCopyButton.tsx Adds exclusion class to copy button component
packages/plugin-llms/src/runtime/LlmsContainer.tsx Adds exclusion class to container component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SoonIter SoonIter merged commit 0a1b248 into main Sep 19, 2025
12 checks passed
@SoonIter SoonIter deleted the syt/fix-theme branch September 19, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants