Skip to content

Conversation

@SoonIter
Copy link
Member

@SoonIter SoonIter commented May 6, 2025

Summary

feat!: support shiki by default, drop prism support

TODO: add external demo of plugin-preview back

<code src="./component.jsx" />

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented May 6, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 6fc32f8
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/681c749d8a977a00085136e0
😎 Deploy Preview https://deploy-preview-2122--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented May 6, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit 6fc32f8
🔍 Latest deploy log https://app.netlify.com/sites/rspress/deploys/681c749dbf34be0007bfc7f7
😎 Deploy Preview https://deploy-preview-2122--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 19 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin
Copy link
Collaborator

JounQin commented May 6, 2025

So no runtime code highlights support anymore?

@SoonIter
Copy link
Member Author

SoonIter commented May 6, 2025

So no runtime code highlights support anymore?

The runtime component will increase the bundle size and will not be recorded in static data such as searchIndex.

it is out of the control of Rspress literally, they are advanced usages

So we can provide a Component with md syntax parsing at runtime just like <ReactMarkdown /> and <CodeBlockRuntime /> and clarify the difference from Rspress compile time

https://fumadocs.dev/docs/ui/components/dynamic-codeblock

@SoonIter SoonIter force-pushed the syt/rspress-shiki branch from 44b69ed to 848cc03 Compare May 6, 2025 11:56
@SoonIter SoonIter requested review from Timeless0911 and removed request for Timeless0911 May 6, 2025 12:28
Timeless0911
Timeless0911 previously approved these changes May 6, 2025
Timeless0911
Timeless0911 previously approved these changes May 8, 2025
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SoonIter SoonIter enabled auto-merge (squash) May 8, 2025 09:14
@SoonIter SoonIter merged commit 44f80f0 into main May 8, 2025
11 checks passed
@SoonIter SoonIter deleted the syt/rspress-shiki branch May 8, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants