-
-
Notifications
You must be signed in to change notification settings - Fork 198
feat(deps)!: bump to react@19 and react-dom@19 by default #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| const reactEntry = ` | ||
| import { render } from 'react-dom'; | ||
| import { createRoot } from 'react-dom/client'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react is the peerDependencies of @rspress/plugin-preview, we should update the peer range if we no longer support react 17.
|
We are getting an error when upgrading to Rspress v2.0.0-beta.0: Should we just ignore the error? Or could Rspress handle this (e.g.: bundle |

Summary
react@19 and react-dom@19
Related Issue
Checklist