Skip to content

Conversation

@SoonIter
Copy link
Member

@SoonIter SoonIter commented Apr 17, 2025

Summary

react@19 and react-dom@19

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter changed the title chore(deps): bump to react@19 by default chore(deps)!: bump to react@19 and react-dom@19 by default Apr 17, 2025
@netlify
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 499e279
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6805db4b09556e00084e01c8
😎 Deploy Preview https://deploy-preview-2073--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 499e279
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/6805db4bf4ef980008e243f7
😎 Deploy Preview https://deploy-preview-2073--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911
Timeless0911 previously approved these changes Apr 17, 2025
@SoonIter SoonIter merged commit 140b135 into main Apr 21, 2025
11 checks passed
@SoonIter SoonIter deleted the react-19 branch April 21, 2025 06:14

const reactEntry = `
import { render } from 'react-dom';
import { createRoot } from 'react-dom/client';
Copy link
Contributor

@Timeless0911 Timeless0911 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react is the peerDependencies of @rspress/plugin-preview, we should update the peer range if we no longer support react 17.

@chenjiahan chenjiahan changed the title chore(deps)!: bump to react@19 and react-dom@19 by default feat(deps)!: bump to react@19 and react-dom@19 by default Apr 21, 2025
@colinaaa
Copy link

We are getting an error when upgrading to Rspress v2.0.0-beta.0:

website
└─┬ @rspress/runtime 2.0.0-beta.0
  └─┬ react-helmet-async 2.0.5
    └── ✕ unmet peer react@"^16.6.0 || ^17.0.0 || ^18.0.0": found 19.1.0 in @rspress/runtime
hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.

lynx-family/lynx-stack#570 (comment)

Should we just ignore the error? Or could Rspress handle this (e.g.: bundle react-helmet-async to avoid using it in dependencies)?

Ref: staylor/react-helmet-async#239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants