Skip to content

Conversation

@childrentime
Copy link
Contributor

@childrentime childrentime commented Jul 8, 2024

Summary

closes: #1237

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit bfe53bf
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/668cd8106b8c760008d45c40
😎 Deploy Preview https://deploy-preview-1240--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@childrentime
Copy link
Contributor Author

fix #1237

@Timeless0911
Copy link
Contributor

LGTM.

You can delete e2e/fixtures/custom-home-footer/styles/index.css and remove line 6-15 in e2e/fixtures/custom-home-footer/rspress.config.ts to make test case more simple.

Can you also write some descriptions to both zh and cn doc about footer to introduce this feature?

@childrentime
Copy link
Contributor Author

Yes, Minister!🤪

@Timeless0911 Timeless0911 enabled auto-merge (squash) July 9, 2024 06:28
@Timeless0911
Copy link
Contributor

This PR will be merged after all CI complete, and you can use nightly version tomorrow. We will not do latest release recently since we are using 1.0.0-alpha version of Rsbuild and Rspack , we want to do a minor release later.

@Timeless0911 Timeless0911 merged commit 30606f9 into web-infra-dev:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: footer支持 模板字符串a标签

2 participants