Merge pull request #1187 from weaviate/fix_optional_moduleconfig_for_custom

Make moduleconfig optional for custom reranker/generative

Author: tsmith023

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 exclude: ^proto/
 repos:
 -   repo: https://github.com/psf/black
-    rev: 24.4.2
+    rev: 23.9.1
     hooks:
     -   id: black
 

requirements-devel.txt

@@ -46,3 +46,4 @@ flake8
 flake8-bugbear==24.4.26
 flake8-comprehensions==3.15.0
 flake8-builtins==2.5.0
+black==23.9.1

weaviate/collections/classes/config.py

@@ -378,9 +378,11 @@ class _GenerativeAnyscale(_GenerativeConfigCreate):
 
 
 class _GenerativeCustom(_GenerativeConfigCreate):
-    module_config: Dict[str, Any]
+    module_config: Optional[Dict[str, Any]]
 
     def _to_dict(self) -> Dict[str, Any]:
+        if self.module_config is None:
+            return {}
         return self.module_config
 
 
@@ -495,9 +497,11 @@ class _RerankerCohereConfig(_RerankerConfigCreate):
 
 
 class _RerankerCustomConfig(_RerankerConfigCreate):
-    module_config: Dict[str, Any]
+    module_config: Optional[Dict[str, Any]]
 
     def _to_dict(self) -> Dict[str, Any]:
+        if self.module_config is None:
+            return {}
         return self.module_config
 
 
@@ -534,7 +538,7 @@ def anyscale(
     @staticmethod
     def custom(
         module_name: str,
-        module_config: Dict[str, Any],
+        module_config: Optional[Dict[str, Any]] = None,
     ) -> _GenerativeConfigCreate:
         """Create a `_GenerativeCustom` object for use when generating using a custom module.
 
@@ -799,7 +803,9 @@ def transformers() -> _RerankerConfigCreate:
         return _RerankerTransformersConfig(reranker=Rerankers.TRANSFORMERS)
 
     @staticmethod
-    def custom(module_name: str, module_config: Dict[str, Any]) -> _RerankerConfigCreate:
+    def custom(
+        module_name: str, module_config: Optional[Dict[str, Any]] = None
+    ) -> _RerankerConfigCreate:
         """Create a `_RerankerCustomConfig` object for use when reranking using a custom module.
 
         Arguments: