Additional comments on ID methods

bboreham · bboreham · commit 7b3b275a3984 · 2021-05-18T15:21:01.000Z
diff --git a/controllers/events/object.go b/controllers/events/object.go
@@ -95,6 +95,7 @@ func (r *EventWatcher) createTraceFromTopLevelObject(ctx context.Context, obj ru
 	return spanData, nil
 }
 
+// create a spanID that will be consistent for a particular object
 func objectToSpanID(m v1.Object) trace.SpanID {
 	f := fnv.New64a()
 	_, _ = f.Write([]byte(m.GetUID()))
@@ -104,6 +105,7 @@ func objectToSpanID(m v1.Object) trace.SpanID {
 	return h
 }
 
+// we include the generation, so changes to the spec will start a new trace.
 func objectToTraceID(m v1.Object) trace.TraceID {
 	f := fnv.New128a()
 	_, _ = f.Write([]byte(m.GetUID()))

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ func (r *EventWatcher) createTraceFromTopLevelObject(ctx context.Context, obj ru`
`95`	`95`	`return spanData, nil`
`96`	`96`	`}`
`97`	`97`
	`98`	`+// create a spanID that will be consistent for a particular object`
`98`	`99`	`func objectToSpanID(m v1.Object) trace.SpanID {`
`99`	`100`	`f := fnv.New64a()`
`100`	`101`	`_, _ = f.Write([]byte(m.GetUID()))`
`@@ -104,6 +105,7 @@ func objectToSpanID(m v1.Object) trace.SpanID {`
`104`	`105`	`return h`
`105`	`106`	`}`
`106`	`107`
	`108`	`+// we include the generation, so changes to the spec will start a new trace.`
`107`	`109`	`func objectToTraceID(m v1.Object) trace.TraceID {`
`108`	`110`	`f := fnv.New128a()`
`109`	`111`	`_, _ = f.Write([]byte(m.GetUID()))`