fix linting x2

Author: Josh Waldrep

app/controllers/simplefin_items_controller.rb

@@ -365,13 +365,13 @@ def apply_relink
           # Move holdings with duplicate guard (security,date,currency)
           if a_new.respond_to?(:holdings)
             a_new.holdings.find_each do |h|
-                if manual.holdings.exists?(security_id: h.security_id, date: h.date, currency: h.currency)
-                  h.destroy!
-                  deleted_holdings += 1
-                else
-                  h.update_columns(account_id: manual.id, updated_at: Time.current)
-                  moved_holdings += 1
-                end
+              if manual.holdings.exists?(security_id: h.security_id, date: h.date, currency: h.currency)
+                h.destroy!
+                deleted_holdings += 1
+              else
+                h.update_columns(account_id: manual.id, updated_at: Time.current)
+                moved_holdings += 1
+              end
             end
           end
 
@@ -440,7 +440,7 @@ def apply_relink
       format.turbo_stream do
         # Render the card partial to HTML to avoid passing a Hash to the stream builder
         # Force HTML format explicitly so Rails does not look for a turbo_stream variant of the partial
-        card_html = render_to_string(partial: "simplefin_items/simplefin_item", formats: [:html], locals: { simplefin_item: @simplefin_item })
+        card_html = render_to_string(partial: "simplefin_items/simplefin_item", formats: [ :html ], locals: { simplefin_item: @simplefin_item })
         render turbo_stream: [
           turbo_stream.remove("modal"),
           turbo_stream.replace(view_context.dom_id(@simplefin_item), card_html)

app/models/account/provider_import_adapter.rb

@@ -142,8 +142,8 @@ def pending_merge?(existing_entry:, incoming_date:, incoming_pending:, incoming_
     end
 
     # Chronology + window: existing must be earlier, incoming must be the later record
-    earlier = [existing_entry.date, incoming_date].min
-    later   = [existing_entry.date, incoming_date].max
+    earlier = [ existing_entry.date, incoming_date ].min
+    later   = [ existing_entry.date, incoming_date ].max
     return false unless later == incoming_date && later > earlier
     return false if (later - earlier).to_i > window_days
 

app/models/simplefin_account/processor.rb

@@ -40,7 +40,7 @@ def auto_relink_existing_manual_account
       name = simplefin_account.name.to_s
       return if name.blank?
       family = simplefin_account.simplefin_item.family
-      norm = ->(s){ s.to_s.downcase.gsub(/\s+/, " ").strip }
+      norm = ->(s) { s.to_s.downcase.gsub(/\s+/, " ").strip }
 
       manuals = family.accounts
         .left_joins(:account_providers)

app/models/simplefin_entry/processor.rb

@@ -163,7 +163,7 @@ def pending?
       return !!explicit unless explicit.nil?
       p = posted_date
       t = transacted_date
-      return (t && p && p > t)
+      t && p && p > t
     end
 
     def merchant

app/models/simplefin_item.rb

@@ -174,7 +174,7 @@ def dedup_simplefin_accounts!
     SimplefinItem.transaction do
       dupes.each_value do |list|
         keeper = list.find { |s| s.current_account.present? } || list.max_by(&:updated_at)
-        (list - [keeper]).each do |dupe|
+        (list - [ keeper ]).each do |dupe|
           keeper_acct = keeper.current_account
           dupe_acct = dupe.current_account
 
@@ -241,8 +241,8 @@ def merge_duplicate_provider_accounts!
       groups.each_value do |links|
         accounts = Account.where(id: links.map(&:account_id))
         # Choose keeper by most entries, else newest by updated_at
-        keeper = accounts.max_by { |a| [a.entries.count, a.updated_at.to_i] }
-        (accounts - [keeper]).each do |dupe|
+        keeper = accounts.max_by { |a| [ a.entries.count, a.updated_at.to_i ] }
+        (accounts - [ keeper ]).each do |dupe|
           # Move entries (avoid duplicates by external_id+source)
           dupe.entries.find_each do |e|
             if e.external_id.present? && e.source.present? && keeper.entries.exists?(external_id: e.external_id, source: e.source)

db/migrate/20251030172500_add_cascade_on_account_deletes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 class AddCascadeOnAccountDeletes < ActiveRecord::Migration[7.0]
   def up
     # Clean up orphaned rows before re-adding foreign keys with cascade

lib/tasks/holdings_tools.rake

@@ -15,9 +15,9 @@
 namespace :sure do
   namespace :holdings do
     desc "Seed a previous snapshot for Day Change demo. Args: holding_id, change_pct=2, days_ago=1, dry_run=true"
-    task :seed_prev_snapshot, [:holding_id, :change_pct, :days_ago, :dry_run] => :environment do |_, args|
+    task :seed_prev_snapshot, [ :holding_id, :change_pct, :days_ago, :dry_run ] => :environment do |_, args|
       kv = {}
-      [args[:holding_id], args[:change_pct], args[:days_ago], args[:dry_run]].each do |raw|
+      [ args[:holding_id], args[:change_pct], args[:days_ago], args[:dry_run] ].each do |raw|
         next unless raw.is_a?(String) && raw.include?("=")
         k, v = raw.split("=", 2)
         kv[k.to_s] = v
@@ -44,7 +44,7 @@ namespace :sure do
       prev.external_id = nil
 
       if dry_run
-        puts({ ok: true, dry_run: true, holding_id: h.id, would_create: prev.attributes.slice("account_id","security_id","date","qty","price","amount","currency") }.to_json)
+        puts({ ok: true, dry_run: true, holding_id: h.id, would_create: prev.attributes.slice("account_id", "security_id", "date", "qty", "price", "amount", "currency") }.to_json)
       else
         prev.save!
         puts({ ok: true, created_prev_id: prev.id, date: prev.date, amount: prev.amount, price: prev.price }.to_json)
@@ -55,7 +55,7 @@ namespace :sure do
     end
 
     desc "Remove a snapshot by holding id. Args: id"
-    task :remove_snapshot, [:id] => :environment do |_, args|
+    task :remove_snapshot, [ :id ] => :environment do |_, args|
       id = args[:id]
       unless id
         puts({ ok: false, error: "usage", message: "Provide id" }.to_json)

lib/tasks/simplefin.rake

@@ -62,7 +62,7 @@ namespace :sure do
       puts({
         ok: false,
         error: "encryption_not_configured",
-        message: "Rails.application.credentials.active_record_encryption is missing; cannot encrypt access_url",
+        message: "Rails.application.credentials.active_record_encryption is missing; cannot encrypt access_url"
       }.to_json)
       exit 1
     end

lib/tasks/simplefin_backfill.rake

@@ -85,20 +85,32 @@ namespace :sure do
             trans  = t[:transacted_at]
 
             # convert to Date where possible for window filtering
-            posted_d = case posted
-                       when String then Date.parse(posted) rescue nil
-                       when Numeric then Time.zone.at(posted).to_date rescue nil
-                       when Date then posted
-                       when Time, DateTime then posted.to_date
-                       else nil
-                       end
-            trans_d  = case trans
-                       when String then Date.parse(trans) rescue nil
-                       when Numeric then Time.zone.at(trans).to_date rescue nil
-                       when Date then trans
-                       when Time, DateTime then trans.to_date
-                       else nil
-                       end
+            posted_d =
+              case posted
+              when String
+                Date.parse(posted) rescue nil
+              when Numeric
+                Time.zone.at(posted).to_date rescue nil
+              when Date
+                posted
+              when Time, DateTime
+                posted.to_date
+              else
+                nil
+              end
+            trans_d =
+              case trans
+              when String
+                Date.parse(trans) rescue nil
+              when Numeric
+                Time.zone.at(trans).to_date rescue nil
+              when Date
+                trans
+              when Time, DateTime
+                trans.to_date
+              else
+                nil
+              end
 
             best = posted_d || trans_d
             # If neither date is available, skip (cannot window-match safely)
@@ -130,7 +142,7 @@ namespace :sure do
             if dry_run
               # Simulate: check if we can composite-match; we won't persist
               entry = acct.entries.find_by(external_id: external_id, source: "simplefin")
-              entry ||= adapter.composite_match(source: "simplefin", name: SimplefinEntry::Processor.new(t, simplefin_account: sfa).send(:name), amount: SimplefinEntry::Processor.new(t, simplefin_account: sfa).send(:amount), date: (posted_d || trans_d), window_days: (acct.accountable_type.in?(["CreditCard", "Loan"]) ? 5 : 3))
+              entry ||= adapter.composite_match(source: "simplefin", name: SimplefinEntry::Processor.new(t, simplefin_account: sfa).send(:name), amount: SimplefinEntry::Processor.new(t, simplefin_account: sfa).send(:amount), date: (posted_d || trans_d), window_days: (acct.accountable_type.in?([ "CreditCard", "Loan" ]) ? 5 : 3))
               matched = entry.present?
               total_matched += 1 if matched
             else
@@ -156,7 +168,7 @@ namespace :sure do
     desc "List and optionally delete known demo SimpleFin entries for a given Account. Args (named): account_id, dry_run=true, pattern"
     task :cleanup_demo_entries, [ :account_id, :dry_run, :pattern ] => :environment do |_, args|
       kv = {}
-      [args[:account_id], args[:dry_run], args[:pattern]].each do |raw|
+      [ args[:account_id], args[:dry_run], args[:pattern] ].each do |raw|
         next unless raw.is_a?(String) && raw.include?("=")
         k, v = raw.split("=", 2)
         kv[k.to_s] = v

lib/tasks/simplefin_debug.rake

@@ -51,7 +51,7 @@ namespace :sure do
           posted: posted,
           transacted_at: trans,
           pending_flag: t[:pending],
-          inferred_pending: (trans.present? && posted.present? && posted.to_i > trans.to_i),
+          inferred_pending: (trans.present? && posted.present? && posted.to_i > trans.to_i)
         }
       end