set SimpleFIN item for balances, remove redundant unpacking, and improve holdings task error

Author: Josh Waldrep

app/controllers/simplefin_items_controller.rb

@@ -1,6 +1,6 @@
 class SimplefinItemsController < ApplicationController
   include SimplefinItems::MapsHelper
-  before_action :set_simplefin_item, only: [ :show, :edit, :update, :destroy, :sync, :setup_accounts, :complete_account_setup, :errors ]
+  before_action :set_simplefin_item, only: [ :show, :edit, :update, :destroy, :sync, :balances, :setup_accounts, :complete_account_setup, :errors ]
 
   def index
     @simplefin_items = Current.family.simplefin_items.active.ordered

app/models/recurring_transaction/identifier.rb

@@ -46,9 +46,6 @@ def identify_recurring_patterns
           # Unpack identifier - either [:merchant, id] or [:name, name_string]
           identifier_type, identifier_value = identifier
 
-          # Support both merchant-based and name-based recurring patterns (main-parity)
-          identifier_type, identifier_value = identifier
-
           pattern = {
             amount: amount,
             currency: currency,

lib/tasks/holdings_tools.rake

@@ -76,7 +76,7 @@ namespace :sure do
       h.destroy!
       puts({ ok: true, removed: id }.to_json)
     rescue => e
-      puts({ ok: false, error: "usage", message: "Provide snapshot_id" }.to_json)
+      puts({ ok: false, error: e.class.name, message: e.message }.to_json)
       exit 1
     end
   end