Merge branch 'pwa_fixes_2' of https://github.com/ByteBard11/sure into pwa_fixes_2

Author: ByteBard11

.cursor/rules/general-rules.mdc

@@ -11,7 +11,6 @@ alwaysApply: true
   - Read [project-design.mdc](mdc:.cursor/rules/project-design.mdc) to understand the codebase
   - Read [project-conventions.mdc](mdc:.cursor/rules/project-conventions.mdc) to understand _how_ to write code for the codebase
   - Read [ui-ux-design-guidelines.mdc](mdc:.cursor/rules/ui-ux-design-guidelines.mdc) to understand how to implement frontend code specifically
-- Ignore i18n methods and files. Hardcode strings in English for now to optimize speed of development.
 - ActiveRecord migrations must inherit from `ActiveRecord::Migration[7.2]`. Do **not** use version 8.0 yet.
 
 ## Prohibited actions

.devcontainer/devcontainer.json

@@ -2,6 +2,10 @@
   "name": "Sure",
   "dockerComposeFile": "docker-compose.yml",
   "service": "app",
+  "runServices": [
+    "db",
+    "redis"
+  ],
   "workspaceFolder": "/workspace",
   "containerEnv": {
     "GIT_EDITOR": "code --wait",

.env.example

@@ -10,6 +10,9 @@
 # Enables self hosting features (should be set to true unless you know what you're doing)
 SELF_HOSTED=true
 
+# Controls onboarding flow (valid: open, closed, invite_only)
+ONBOARDING_STATE=open
+
 # Secret key used to encrypt credentials (https://api.rubyonrails.org/v7.1.3.2/classes/Rails/Application.html#method-i-secret_key_base)
 # Has to be a random string, generated eg. by running `openssl rand -hex 64`
 SECRET_KEY_BASE=secret-value
@@ -32,10 +35,15 @@ LANGFUSE_SECRET_KEY=
 # Get it here: https://twelvedata.com/
 TWELVE_DATA_API_KEY=
 
-# Optional: Twelve Data provider is the default for exchange rates and securities.
+# Optional: Provider selection for exchange rates and securities data
+# Options: twelve_data (default), yahoo_finance
 EXCHANGE_RATE_PROVIDER=twelve_data
 SECURITIES_PROVIDER=twelve_data
 
+# Alternative: Use Yahoo Finance as provider (free, no API key required)
+# EXCHANGE_RATE_PROVIDER=yahoo_finance
+# SECURITIES_PROVIDER=yahoo_finance
+
 # Custom port config
 # For users who have other applications listening at 3000, this allows them to set a value puma will listen to.
 PORT=3000
@@ -107,3 +115,12 @@ BRAND_NAME=
 # CLOUDFLARE_SECRET_ACCESS_KEY=
 # CLOUDFLARE_BUCKET=
 #
+# Generic S3
+# ==========
+# ACTIVE_STORAGE_SERVICE=generic_s3 <- Enables Generic S3 storage
+# GENERIC_S3_ACCESS_KEY_ID=
+# GENERIC_S3_SECRET_ACCESS_KEY=
+# GENERIC_S3_REGION=
+# GENERIC_S3_BUCKET=
+# GENERIC_S3_ENDPOINT=
+# GENERIC_S3_FORCE_PATH_STYLE= <- defaults to false

.env.local.example

@@ -1,6 +1,9 @@
 # To enable / disable self-hosting features.
 SELF_HOSTED = true
 
+# Controls onboarding flow (valid: open, closed, invite_only)
+ONBOARDING_STATE = open
+
 # Enable Twelve market data (careful, this will use your API credits)
 TWELVE_DATA_API_KEY =
 

.env.test.example

@@ -1,5 +1,8 @@
 SELF_HOSTED=false
 
+# Controls onboarding flow (valid: open, closed, invite_only)
+ONBOARDING_STATE=open
+
 # OpenID Connect for tests
 OIDC_ISSUER=
 OIDC_CLIENT_ID=
@@ -21,4 +24,4 @@ OIDC_REDIRECT_URI=http://localhost:3000/auth/openid_connect/callback
 COVERAGE=false
 
 # Set to true to run test suite serially
-DISABLE_PARALLELIZATION=false
+DISABLE_PARALLELIZATION=false

.gitignore

@@ -30,6 +30,7 @@
 /tmp/storage/*
 !/tmp/storage/
 !/tmp/storage/.keep
+/db/development.sqlite3
 
 /public/assets
 
@@ -106,3 +107,6 @@ scripts/
 .windsurfrules
 .cursor/rules/dev_workflow.mdc
 .cursor/rules/taskmaster.mdc
+
+# Local Junie helpers
+.junie/

CLAUDE.md

@@ -56,8 +56,7 @@ Only proceed with pull request creation if ALL checks pass.
 - Use `Current.family` for the current family. Do NOT use `current_family`.
 
 ### Development Guidelines
-- Prior to generating any code, carefully read the project conventions and guidelines
-- Ignore i18n methods and files. Hardcode strings in English for now to optimize speed of development
+- Carefully read project conventions and guidelines before generating any code.
 - Do not run `rails server` in your responses
 - Do not run `touch tmp/restart.txt`
 - Do not run `rails credentials`
@@ -112,6 +111,15 @@ Sidekiq handles asynchronous tasks:
   - Always use functional tokens (e.g., `text-primary` not `text-white`)
   - Prefer semantic HTML elements over JS components
   - Use `icon` helper for icons, never `lucide_icon` directly
+- **i18n**: All user-facing strings must use localization (i18n). Update locale files for each new or changed element.
+
+### Internationalization (i18n) Guidelines
+- **Key Organization**: Use hierarchical keys by feature: `accounts.index.title`, `transactions.form.amount_label`
+- **Translation Helper**: Always use `t()` helper for user-facing strings
+- **Interpolation**: Use for dynamic content: `t("users.greeting", name: user.name)`
+- **Pluralization**: Use Rails pluralization: `t("transactions.count", count: @transactions.count)`
+- **Locale Files**: Update `config/locales/en.yml` for new strings
+- **Missing Translations**: Configure to raise errors in development for missing keys
 
 ### Multi-Currency Support
 - All monetary values stored in base currency (user's primary currency)
@@ -220,11 +228,36 @@ Sidekiq handles asynchronous tasks:
 ```erb
 <!-- GOOD: Declarative - HTML declares what happens -->
 <div data-controller="toggle">
-  <button data-action="click->toggle#toggle" data-toggle-target="button">Show</button>
-  <div data-toggle-target="content" class="hidden">Hello World!</div>
+  <button data-action="click->toggle#toggle" data-toggle-target="button">
+    <%= t("components.transaction_details.show_details") %>
+  </button>
+  <div data-toggle-target="content" class="hidden">
+    <p><%= t("components.transaction_details.amount_label") %>: <%= @transaction.amount %></p>
+    <p><%= t("components.transaction_details.date_label") %>: <%= @transaction.date %></p>
+    <p><%= t("components.transaction_details.category_label") %>: <%= @transaction.category.name %></p>
+  </div>
 </div>
 ```
 
+**Example locale file structure (config/locales/en.yml):**
+```yaml
+en:
+  components:
+    transaction_details:
+      show_details: "Show Details"
+      hide_details: "Hide Details"
+      amount_label: "Amount"
+      date_label: "Date"
+      category_label: "Category"
+```
+
+**i18n Best Practices:**
+- Organize keys by feature/component: `components.transaction_details.show_details`
+- Use descriptive key names that indicate purpose: `show_details` not `button`
+- Group related translations together in the same namespace
+- Use interpolation for dynamic content: `t("users.welcome", name: user.name)`
+- Always update locale files when adding new user-facing strings
+
 **Controller Best Practices:**
 - Keep controllers lightweight and simple (< 7 targets)
 - Use private methods and expose clear public API

README.md

@@ -86,7 +86,9 @@ For further instructions, see guides below.
 - [Windows dev setup](https://github.com/we-promise/sure/wiki/Windows-Dev-Setup-Guide)
 - Dev containers - visit [this guide](https://code.visualstudio.com/docs/devcontainers/containers)
 
-### One click deploys
+### One-click
+
+[![Run on PikaPods](https://www.pikapods.com/static/run-button.svg)](https://www.pikapods.com/pods?run=maybe)
 
 [![Deploy on Railway](https://railway.com/button.svg)](https://railway.com/deploy/sure?referralCode=CW_fPQ)
 

app/components/UI/account/activity_feed.html.erb

@@ -1,23 +1,23 @@
 <%= turbo_frame_tag dom_id(account, "entries") do %>
   <div class="bg-container p-5 shadow-border-xs rounded-xl">
     <div class="flex items-center justify-between mb-4" data-testid="activity-menu">
-      <%= tag.h2 "Activity", class: "font-medium text-lg" %>
+      <%= tag.h2 t("accounts.show.activity.title"), class: "font-medium text-lg" %>
 
       <% if account.manual? %>
         <%= render DS::Menu.new(variant: "button") do |menu| %>
-          <% menu.with_button(text: "New", variant: "secondary", icon: "plus") %>
+          <% menu.with_button(text: t("accounts.show.activity.new"), variant: "secondary", icon: "plus") %>
 
           <% menu.with_item(
               variant: "link",
-              text: "New balance",
+              text: t("accounts.show.activity.new_balance"),
               icon: "circle-dollar-sign",
               href: new_valuation_path(account_id: account.id),
               data: { turbo_frame: :modal }) %>
 
           <% unless account.crypto? %>
             <% menu.with_item(
                 variant: "link",
-                text: "New transaction",
+                text: t("accounts.show.activity.new_transaction"),
                 icon: "credit-card",
                 href: account.investment? ? new_trade_path(account_id: account.id) : new_transaction_path(account_id: account.id),
                 data: { turbo_frame: :modal }) %>
@@ -40,7 +40,7 @@
               <%= hidden_field_tag :account_id, account.id %>
 
               <%= form.search_field :search,
-                            placeholder: "Search entries by name",
+                            placeholder: t("accounts.show.activity.search.placeholder"),
                             value: search,
                             class: "form-field__input placeholder:text-sm placeholder:text-secondary",
                             "data-auto-submit-form-target": "auto" %>
@@ -51,7 +51,7 @@
     </div>
 
     <% if activity_dates.empty? %>
-      <p class="text-secondary text-sm p-4">No entries yet</p>
+      <%= tag.p t("accounts.show.activity.no_entries"), class: "text-secondary text-sm p-4" %>
     <% else %>
       <%= tag.div id: dom_id(account, "entries_bulk_select"),
                 data: {
@@ -68,10 +68,10 @@
             <%= check_box_tag "selection_entry",
                               class: "checkbox checkbox--light",
                               data: { action: "bulk-select#togglePageSelection" } %>
-            <p>Date</p>
+            <%= tag.p t("accounts.show.activity.date") %>
           </div>
 
-          <%= tag.p "Amount", class: "col-span-4 justify-self-end" %>
+          <%= tag.p t("accounts.show.activity.amount"), class: "col-span-4 justify-self-end" %>
         </div>
 
         <div>

app/controllers/accounts_controller.rb

@@ -28,7 +28,17 @@ def show
 
   def sync
     unless @account.syncing?
-      @account.sync_later
+      if @account.linked?
+        # Sync all provider items for this account
+        # Each provider item will trigger an account sync when complete
+        @account.account_providers.each do |account_provider|
+          item = account_provider.adapter&.item
+          item&.sync_later if item && !item.syncing?
+        end
+      else
+        # Manual accounts just need balance materialization
+        @account.sync_later
+      end
     end
 
     redirect_to account_path(@account)