Skip to content

Commit c4930f1

Browse files
authored
[worker] fix: create a new event loop if none exists (volcengine#3703)
### What does this PR do? I am working on integrating transferqueue into verl. Specifically, we convert metadata into dataproto in the `register` method of `single_controller/base/decorator.py/`. In this step, `asyncio.run(tq_client.async_get_data(metadata)` is called to get the specific data. If `asyncio.run` and `asyncio.get_event_loop` are called sequentially in the same thread, a RuntimeError: `There is no current event loop in thread %r` is thrown. This PR fixes the above-mentioned issue. ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent 3da1977 commit c4930f1

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

verl/workers/fsdp_workers.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -902,7 +902,11 @@ def generate_sequences(self, prompts: DataProto):
902902

903903
timing_generate = {}
904904
if self._is_actor: # For rollout only, we do not switch context.
905-
loop = asyncio.get_event_loop()
905+
try:
906+
loop = asyncio.get_event_loop()
907+
except RuntimeError:
908+
loop = asyncio.new_event_loop()
909+
asyncio.set_event_loop(loop)
906910
loop.run_until_complete(self.rollout_mode())
907911
log_gpu_memory_usage("After switch to rollout mode", logger=logger)
908912

verl/workers/megatron_workers.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,11 @@ def generate_sequences(self, prompts: DataProto):
669669

670670
timing_generate = {}
671671
if self._is_actor: # For rollout only, we do not switch context.
672-
loop = asyncio.get_event_loop()
672+
try:
673+
loop = asyncio.get_event_loop()
674+
except RuntimeError:
675+
loop = asyncio.new_event_loop()
676+
asyncio.set_event_loop(loop)
673677
loop.run_until_complete(self.rollout_mode())
674678
log_gpu_memory_usage("After switch to rollout mode", logger=logger)
675679

0 commit comments

Comments
 (0)