Skip to content

Commit 44ac17b

Browse files
authored
[rollout] fix: qwen2_vl position_ids shape mismatch (volcengine#3653)
### What does this PR do? > Fix qwen2_vl position_id shape mismatch: `verl/models/transformers/qwen2_vl.py:process_position_ids` expects `position_ids` to have a shape of `(4, batch_size, seq_length)` but `verl/experimental/agent_loop/agent_loop.py:generate_sequences` returns `(batch_size, 3, seq_length)` (which will be transposed to `(3, batch_size, seq_length)`), ignoring the text dimension. This PR follows the relevant code in `verl/utils/dataset/rl_dataset.py` to fix the issue. ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). Not applicable. - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent 86856fb commit 44ac17b

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

verl/experimental/agent_loop/agent_loop.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,14 +589,20 @@ async def _run_agent_loop(
589589
video_grid_thw = multi_modal_inputs.get("video_grid_thw")
590590
second_per_grid_ts = multi_modal_inputs.get("second_per_grid_ts")
591591

592-
position_ids = get_rope_index(
592+
vision_position_ids = get_rope_index(
593593
self.processor,
594594
input_ids=input_ids.squeeze(0),
595595
image_grid_thw=image_grid_thw,
596596
video_grid_thw=video_grid_thw,
597597
second_per_grid_ts=second_per_grid_ts,
598598
attention_mask=attention_mask.squeeze(0),
599599
).unsqueeze(0) # (1, 3, seq_len)
600+
601+
valid_mask = attention_mask[0].bool()
602+
text_position_ids = torch.ones((1, len(input_ids[0])), dtype=torch.long)
603+
text_position_ids[0, valid_mask] = torch.arange(valid_mask.sum().item())
604+
text_position_ids = text_position_ids.unsqueeze(0)
605+
position_ids = torch.cat((text_position_ids, vision_position_ids), dim=1) # (1, 4, seq_length)
600606
else:
601607
position_ids = compute_position_id_with_mask(attention_mask) # (1, seq_len)
602608
enable_async_reward = (

0 commit comments

Comments
 (0)