Skip to content

Commit 681c447

Browse files
Update CoinFabrik_On_Ink_Integration_Tests_2.md
1 parent 5cbb6e8 commit 681c447

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

applications/CoinFabrik_On_Ink_Integration_Tests_2.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ For these two sets of functions, with explicit implementation plans and pending
110110

111111
Considering the dependency of several functions on the implementation of `instantiate_contract()`, we propose to split the work above into two milestones. Before implementing `instantiate_contract()`, we will also make modifications to the way accounts work in integration tests in order for them to be consistent with behavior in e2e. All these implementations or modifications will be pushed into the [ink! project repository](https://github.com/paritytech/ink ) following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md).
112112

113+
We have also identified a bug in the e2e tests. When contracts are in a workspace with dependencies defined in `Cargo.toml`, and these dependencies are inherited in contracts, the e2e tests fail to compile. However, manually specifying dependencies in each contract resolves the issue. We've logged this bug on GitHub [Issue #1919](https://github.com/paritytech/ink/issues/1919) and will be addressing it as part of our work in Milestone 1.
114+
113115
## Development Roadmap :nut_and_bolt:
114116

115117
### Overview
@@ -135,7 +137,7 @@ Considering the dependency of several functions on the implementation of `instan
135137
| 0c. | Testing and Testing Guide | The newly developed functionalities will be documented and tested following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md). A testing guide will be included.
136138
| 0d. | Docker | Does not apply at this stage.
137139
| 0e. | Article | We will publish an updated report summary in our blog at https://blog.coinfabrik.com/.
138-
**1** | Develop | We will develop the missing functionalities or correct implementation differences for functions 1-default_accounts(), 2-set_contract_storage() and 3-instantiate_contract(). All these implementations or modifications will be pushed into the [ink! project repository](https://github.com/paritytech/ink) following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md).
140+
**1** | Develop | We will develop the missing functionalities or correct implementation differences for functions 1-default_accounts(), 2-set_contract_storage() and 3-instantiate_contract(). All these implementations or modifications will be pushed into the [ink! project repository](https://github.com/paritytech/ink) following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md).<br><br>If applicable, we will develop additional tests or make ad hoc improvements to the ink codebase necessary for the completion of this milestone. Particularly for functions declared outside the env_access.rs file that might be related to integration or end-to-end testing.
139141
**2** | Review and Estimate | We will review the remaining 13 unanalysed functions, which are implemented both for integration and e2e tests. For these functions we will provide documentation, a test case and an implementation estimation if applicable. These correspond to functions issue numbers 12 through 24.
140142
**3** | Quality Assurance | We will adhere to existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md) and add necessary tests to integrate the new implemented or corrected functions to the [ink! project repository](https://github.com/paritytech/ink).
141143

@@ -151,7 +153,7 @@ Considering the dependency of several functions on the implementation of `instan
151153
| 0c. | Testing and Testing Guide | The newly developed functionalities will be documented and tested following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md). A testing guide will be included.
152154
| 0d. | Docker | Does not apply at this stage.
153155
| 0e. | Article | We will publish an updated report summary in our blog at https://blog.coinfabrik.com/.
154-
**1** | Development | We will implement the missing functionalities or resolve implementation differences for function issues 4-code_hash(), 6-own_code_hash(), 7-invoke_contract(), 8-invoke_contract_delegate(), 9-caller_is_origin() and 10-set_code_hash).<br><br>We will implement any missing functionalities, or correct implementation differences, for the 13 functions with issues 12 through 24. For this group, we will document any additional work required in order to ensure consistency between integration and e2e tests.<br><br>All these implementations or modifications will be pushed into the [ink! project repository](https://github.com/paritytech/ink) following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md) .
156+
**1** | Development | We will implement the missing functionalities or resolve implementation differences for function issues 4-code_hash(), 6-own_code_hash(), 7-invoke_contract(), 8-invoke_contract_delegate(), 9-caller_is_origin() and 10-set_code_hash).<br><br>We will implement any missing functionalities, or correct implementation differences, for the 13 functions with issues 12 through 24. For this group, we will document any additional work required in order to ensure consistency between integration and e2e tests.<br><br>All these implementations or modifications will be pushed into the [ink! project repository](https://github.com/paritytech/ink) following existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md).<br><br>If applicable, we will develop additional tests or make ad hoc improvements to the ink codebase necessary for the completion of this milestone. Particularly for functions declared outside the env_access.rs file that might be related to integration or end-to-end testing.
155157
**2** | Quality Assurance| We will adhere to existing [contribution guidelines](https://github.com/paritytech/ink/blob/master/CONTRIBUTING.md) and add necessary tests to integrate the new implemented or corrected functions to the [ink! project repository](https://github.com/paritytech/ink).
156158

157159

0 commit comments

Comments
 (0)