Editorial: validate proxy in browser.createUserContext
#988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Aug 22, 2025
Contributor
|
@sadym-chromium btw I do not think it is editorial |
whimboo
reviewed
Aug 22, 2025
Contributor
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
Up, pressed the merge button for the review. Looks good to me as well.
github-actions bot
added a commit
that referenced
this pull request
Aug 22, 2025
SHA: b7393ef Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sadym-chromium
added a commit
that referenced
this pull request
Aug 22, 2025
)" This reverts commit b7393ef.
Contributor
Author
Well, we have an issue with this PR: w3c/webdriver#1920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use WebDriver classic's "deserialize as a proxy" in
browser.createUserContextforproxyparameter.We have a bunch of WPT tests checking the validity of
proxyinbrowser.createUserContext, while the BiDi specification does not have the validation at all.Preview | Diff