fix(lifecycle): scope might changed when call hook#13070
Merged
yyx990803 merged 2 commits intovuejs:mainfrom Oct 22, 2023
Merged
fix(lifecycle): scope might changed when call hook#13070yyx990803 merged 2 commits intovuejs:mainfrom
yyx990803 merged 2 commits intovuejs:mainfrom
Conversation
f40e9dc to
116c21d
Compare
|
This'd be great to have reviewed and merged. We're in the middle of moving a fairly large Vue 2 + Vuex application into Pinia, and we'd like to avoid the boilerplate in working around this issue. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This pull request's issue originates from a specific problem mentioned in vuejs/pinia#1800 . Due to the potential for callHook to modify the upper-level scope's behavior of collecting effects, it subsequently leads to incorrect effects being torn down when stopping in the wrong scope.