Skip to content

Fix scroll when going back to initial route - #1586

Merged
yyx990803 merged 2 commits into
vuejs:devfrom
hworld:fix-initial-scroll
Oct 11, 2017
Merged

Fix scroll when going back to initial route#1586
yyx990803 merged 2 commits into
vuejs:devfrom
hworld:fix-initial-scroll

Conversation

@hworld

@hworld hworld commented Jul 11, 2017

Copy link
Copy Markdown
Contributor

Should fix: #1585

I added a new e2e test that sets scrollRestoration to manual. Without the fix the test correctly fails.

@posva posva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix on Firefox and the bug is still happening though... I thought you used dev but you created a new branch 馃憤

@posva posva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually as well
@yyx990803 I cannot see anything else, can you take a look? (1 line bug fix for Firefox)

@posva

posva commented Aug 16, 2017

Copy link
Copy Markdown
Member

ping @yyx990803

@yyx990803
yyx990803 merged commit c166822 into vuejs:dev Oct 11, 2017
@djune

djune commented Nov 15, 2017

Copy link
Copy Markdown

@hworld
Throw an exception use IE9 test
// Fix for #1585 for Firefox window.history.replaceState({ key: getStateKey() }, '');

image

@JounQin

JounQin commented Nov 15, 2017

Copy link
Copy Markdown
Contributor

@djune It has been fixed in #1835 which has not been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scrollBehavior doesn't work for initial route in Firefox

5 participants