refactor(language-core): reimplement writeGlobalTypes without side effects

Author: johnsoncodehk

packages/component-meta/lib/base.ts

@@ -93,21 +93,21 @@ function baseCreate(
 	rootPath: string,
 	globalComponentName: string,
 ) {
-	let [commandLine, _fileNames] = getConfigAndFiles();
+	let [{ vueOptions, options, projectReferences }, fileNames] = getConfigAndFiles();
 	/**
 	 * Used to lookup if a file is referenced.
 	 */
-	let fileNames = new Set(_fileNames.map(path => path.replace(windowsPathReg, '/')));
+	let fileNamesSet = new Set(fileNames.map(path => path.replace(windowsPathReg, '/')));
 	let projectVersion = 0;
 
-	vue.writeGlobalTypes(commandLine.vueOptions, ts.sys.writeFile);
+	vueOptions.globalTypesPath = vue.createGlobalTypesWriter(vueOptions, ts.sys.writeFile);
 
 	const projectHost: TypeScriptProjectHost = {
 		getCurrentDirectory: () => rootPath,
 		getProjectVersion: () => projectVersion.toString(),
-		getCompilationSettings: () => commandLine.options,
-		getScriptFileNames: () => [...fileNames],
-		getProjectReferences: () => commandLine.projectReferences,
+		getCompilationSettings: () => options,
+		getScriptFileNames: () => [...fileNamesSet],
+		getProjectReferences: () => projectReferences,
 	};
 	const globalComponentSnapshot = ts.ScriptSnapshot.fromString('<script setup lang="ts"></script>');
 	const scriptSnapshots = new Map<string, ts.IScriptSnapshot | undefined>();
@@ -126,7 +126,7 @@ function baseCreate(
 	const vueLanguagePlugin = vue.createVueLanguagePlugin<string>(
 		ts,
 		projectHost.getCompilationSettings(),
-		commandLine.vueOptions,
+		vueOptions,
 		id => id,
 	);
 	const language = vue.createLanguage(
@@ -179,7 +179,7 @@ function baseCreate(
 		const getScriptKind = languageServiceHost.getScriptKind?.bind(languageServiceHost);
 		languageServiceHost.getScriptKind = fileName => {
 			const scriptKind = getScriptKind!(fileName);
-			if (commandLine.vueOptions.extensions.some(ext => fileName.endsWith(ext))) {
+			if (vueOptions.extensions.some(ext => fileName.endsWith(ext))) {
 				if (scriptKind === ts.ScriptKind.JS) {
 					return ts.ScriptKind.TS;
 				}
@@ -200,17 +200,18 @@ function baseCreate(
 			fileName = fileName.replace(windowsPathReg, '/');
 			scriptSnapshots.set(fileName, ts.ScriptSnapshot.fromString(text));
 			// Ensure the file is referenced
-			fileNames.add(fileName);
+			fileNamesSet.add(fileName);
 			projectVersion++;
 		},
 		deleteFile(fileName: string) {
 			fileName = fileName.replace(windowsPathReg, '/');
-			fileNames.delete(fileName);
+			fileNamesSet.delete(fileName);
 			projectVersion++;
 		},
 		reload() {
-			[commandLine, _fileNames] = getConfigAndFiles();
-			fileNames = new Set(_fileNames.map(path => path.replace(windowsPathReg, '/')));
+			[{ vueOptions, options, projectReferences }, fileNames] = getConfigAndFiles();
+			vueOptions.globalTypesPath = vue.createGlobalTypesWriter(vueOptions, ts.sys.writeFile);
+			fileNamesSet = new Set(fileNames.map(path => path.replace(windowsPathReg, '/')));
 			this.clearCache();
 		},
 		clearCache() {
@@ -228,7 +229,7 @@ function baseCreate(
 
 	function getMetaFileName(fileName: string) {
 		return (
-			commandLine.vueOptions.extensions.some(ext => fileName.endsWith(ext))
+			vueOptions.extensions.some(ext => fileName.endsWith(ext))
 				? fileName
 				: fileName.slice(0, fileName.lastIndexOf('.'))
 		) + '.meta.ts';

packages/language-core/lib/compilerOptions.ts

@@ -323,13 +323,13 @@ export function getDefaultCompilerOptions(target = 99, lib = 'vue', strictTempla
 	};
 }
 
-export function writeGlobalTypes(
+export function createGlobalTypesWriter(
 	vueOptions: VueCompilerOptions,
 	writeFile: (fileName: string, data: string) => void,
 ) {
 	const writed = new Set<string>();
 	const { globalTypesPath } = vueOptions;
-	vueOptions.globalTypesPath = (fileName: string) => {
+	return (fileName: string) => {
 		const result = globalTypesPath(fileName);
 		if (result && !writed.has(result)) {
 			writed.add(result);

packages/tsc/index.ts

@@ -17,7 +17,7 @@ export function run(tscPath = require.resolve('typescript/lib/tsc')) {
 					? vue.createParsedCommandLine(ts, ts.sys, configFilePath.replace(windowsPathReg, '/')).vueOptions
 					: vue.createParsedCommandLineByJson(ts, ts.sys, (options.host ?? ts.sys).getCurrentDirectory(), {})
 						.vueOptions;
-				vue.writeGlobalTypes(vueOptions, ts.sys.writeFile);
+				vueOptions.globalTypesPath = vue.createGlobalTypesWriter(vueOptions, ts.sys.writeFile);
 				const allExtensions = vue.getAllExtensions(vueOptions);
 				if (
 					runExtensions.length === allExtensions.length

packages/tsc/tests/dts.spec.ts

@@ -36,7 +36,7 @@ describe('vue-tsc-dts', () => {
 			vueOptions.target = 99;
 			vueOptions.extensions = ['vue', 'cext'];
 		}
-		vue.writeGlobalTypes(vueOptions, ts.sys.writeFile);
+		vueOptions.globalTypesPath = vue.createGlobalTypesWriter(vueOptions, ts.sys.writeFile);
 		const vueLanguagePlugin = vue.createVueLanguagePlugin<string>(
 			ts,
 			options.options,

packages/typescript-plugin/index.ts

@@ -23,8 +23,7 @@ export = createLanguageServicePlugin(
 			vueOptions,
 			id => id,
 		);
-
-		vue.writeGlobalTypes(vueOptions, ts.sys.writeFile);
+		vueOptions.globalTypesPath = vue.createGlobalTypesWriter(vueOptions, ts.sys.writeFile);
 		addVueCommands();
 
 		return {