Skip to content

Catch exception for Function.toString on Proxies etc. #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2018
Merged

Catch exception for Function.toString on Proxies etc. #635

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c95ab5
Catch exception for Function toString on Proxies etc.
sbward Mar 4, 2018
7244c79
Fix string const assign
sbward Mar 4, 2018
be053bb
test: add proxied function example
Mar 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,12 @@ export function getCustomComponentDefinitionDetails (def) {
}

export function getCustomFunctionDetails (func) {
const string = Function.prototype.toString.call(func) || ''
let string = ''
try {
string = Function.prototype.toString.call(func)
} catch (e) {
// Func is probably a Proxy, which can break Function.prototype.toString()
}
const matches = string.match(/\(.*\)/)
const args = matches ? matches[0] : '(?)'
return {
Expand Down