Catch exception for Function.toString on Proxies etc. #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #568
Sometimes a Function Proxy gets inspected by
getCustomFunctionDetails(), which breaks becauseFunction.prototype.toStringdoesn't always work with Proxy objects.This patch simply catches the
TypeErrorand allowsvue-devtoolsto continue rendering the Component details even if it contains funky Function Proxies. Currently if this occurs the Component detail view doesn't show, which leaves developers stuck tracking down the cause of the issue without the help ofvue-devtools. This patch will at least allow the Component details to render, but the Function Proxy in question will not show argument details.There might be a way to continue rendering the arguments for certain Function Proxies but I don't think it would be completely general.