Skip to content

Conversation

@crswll
Copy link
Contributor

@crswll crswll commented Feb 11, 2018

I added a title attribute: "Available as $vm0 in the console."

Also changed == $vm0 to = $vm0 since it seems like something was assigned instead of just equal to something. I was also considering maybe = window.$vm0 to make it even more clear?

Let me know what you think.

@psi-4ward
Copy link

I thought about storing a reference of the focused component.
It's often hard to click through the component tree inside dev-tools but got better with "Inspect component". Why not just add a window onClick listener and store the topmost component in $vm1 ?

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalsnik michalsnik requested a review from Akryum March 11, 2018 10:35
@Akryum Akryum added this to the v4.1.4 milestone Mar 11, 2018
@Akryum Akryum self-assigned this Mar 11, 2018
@Akryum Akryum merged commit 2ea11f5 into vuejs:master Mar 11, 2018
@crswll crswll deleted the console-notice branch April 4, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants