Skip to content

Commit 2c039ff

Browse files
Add ragged_batches to mock model, fix test paths, minor docs
1 parent 70d4a6b commit 2c039ff

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

fiftyone/utils/qwen3_vl.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,8 +421,9 @@ def embed(self, arg):
421421
"""Generate embedding for a single image or video.
422422
423423
Args:
424-
arg: a PIL image, numpy array, torch tensor, or an open
425-
``eta.core.video.FFmpegVideoReader``
424+
arg: a PIL image, numpy array, torch tensor, or an active
425+
(entered) ``eta.core.video.FFmpegVideoReader`` context
426+
manager
426427
427428
Returns:
428429
a 1D numpy array embedding

tests/unittests/utils/test_qwen3_vl.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,10 @@ def has_embeddings(self):
476476
def embed(self, arg):
477477
return np.random.randn(8).astype(np.float32)
478478

479+
@property
480+
def ragged_batches(self):
481+
return True
482+
479483
def __enter__(self):
480484
return self
481485

@@ -490,7 +494,7 @@ def test_mode_none_video_dataset(self):
490494
ds = fo.Dataset()
491495
ds.media_type = "video"
492496
ds.add_sample(fo.Sample(
493-
filepath="C:/Users/cnort/Videos/Captures/Counter-Strike 2 2023-10-03 12-54-09.mp4"
497+
filepath="/tmp/test_video.mp4"
494498
))
495499
ds.compute_embeddings(model, embeddings_field="emb")
496500
assert ds.has_sample_field("emb")
@@ -505,7 +509,7 @@ def test_explicit_image_not_overridden(self):
505509
ds = fo.Dataset()
506510
ds.media_type = "video"
507511
ds.add_sample(fo.Sample(
508-
filepath="C:/Users/cnort/Videos/Captures/Counter-Strike 2 2023-10-03 12-54-09.mp4"
512+
filepath="/tmp/test_video.mp4"
509513
))
510514
ds.compute_embeddings(model, embeddings_field="emb")
511515
assert ds.has_frame_field("emb")
@@ -531,5 +535,16 @@ def test_mode_none_image_dataset(self):
531535
os.remove(tmp)
532536

533537

538+
class TestQwen3VLVideoConfig:
539+
"""Test video-specific config defaults"""
540+
541+
def test_video_fps_default(self):
542+
"""Test default video_fps is 2.0"""
543+
from fiftyone.utils.qwen3_vl import Qwen3VLModelConfig
544+
545+
config = Qwen3VLModelConfig({})
546+
assert config.video_fps == 2.0
547+
548+
534549
if __name__ == "__main__":
535550
pytest.main([__file__, "-v"])

0 commit comments

Comments
 (0)