Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion verl/workers/fsdp_workers.py
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,11 @@ def generate_sequences(self, prompts: DataProto):

timing_generate = {}
if self._is_actor: # For rollout only, we do not switch context.
loop = asyncio.get_event_loop()
try:
loop = asyncio.get_event_loop()
except RuntimeError:
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
loop.run_until_complete(self.rollout_mode())
log_gpu_memory_usage("After switch to rollout mode", logger=logger)

Expand Down
6 changes: 5 additions & 1 deletion verl/workers/megatron_workers.py
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,11 @@ def generate_sequences(self, prompts: DataProto):

timing_generate = {}
if self._is_actor: # For rollout only, we do not switch context.
loop = asyncio.get_event_loop()
try:
loop = asyncio.get_event_loop()
except RuntimeError:
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
loop.run_until_complete(self.rollout_mode())
log_gpu_memory_usage("After switch to rollout mode", logger=logger)

Expand Down
4 changes: 2 additions & 2 deletions verl/workers/rollout/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ def initialize_request(cls, values):
# Only log the warning to avoid truncating in the middle of generation prompt. Consider raising an
# error for this case in the future.
# Ensure batch_data_id exists with default value if not provided
if 'batch_data_id' not in values:
values['batch_data_id'] = cls.model_fields['batch_data_id'].default
if "batch_data_id" not in values:
values["batch_data_id"] = cls.model_fields["batch_data_id"].default
logger.warning(
f"Prompt {values['batch_data_id']} has length {values['input_ids'].shape[-1]} "
f"which is greater than max_prompt_len {max_prompt_len} after applied chat template with tools."
Expand Down
Loading