Skip to content

Commit fc05070

Browse files
Maxwell-JiaMaxwell-Jia
andauthored
[ckpt] fix: TypeError when save VL model ckpt (#3268)
### What does this PR do? Fix #3267 . ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: https://github.com/volcengine/verl/pulls?q=is%3Apr+is%3Aopen+checkpoint+ - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [x] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [x] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) Co-authored-by: Maxwell-Jia <[email protected]>
1 parent cc2799b commit fc05070

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

verl/utils/checkpoint/fsdp_checkpoint_manager.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,20 @@ def save_checkpoint(self, local_path: str, hdfs_path: str = None, global_step: i
321321

322322
auto_model_cls = AutoModelForCausalLM
323323
elif "ForConditionalGeneration" in model_config.architectures[0]:
324-
from transformers import AutoModelForVision2Seq
324+
# Handle different transformers versions for Vision2Seq models
325+
import transformers
326+
from packaging import version
325327

326-
auto_model_cls = AutoModelForVision2Seq
328+
if version.parse(transformers.__version__) >= version.parse("4.54.0"):
329+
# transformers >= 4.54.0 uses AutoModelForImageTextToText
330+
from transformers import AutoModelForImageTextToText
331+
332+
auto_model_cls = AutoModelForImageTextToText
333+
else:
334+
# transformers < 4.54.0 uses AutoModelForVision2Seq
335+
from transformers import AutoModelForVision2Seq
336+
337+
auto_model_cls = AutoModelForVision2Seq
327338
else:
328339
raise NotImplementedError(f"Unknown architecture {model_config['architectures']}")
329340

0 commit comments

Comments
 (0)