Skip to content

Commit d45d049

Browse files
HJSangHejian Sanggemini-code-assist[bot]
authored
[rollout,sglang] fix: get_tool_call_parser_type for gpt-oss models in sglang rollout (#3661)
### What does this PR do? > Add **concise** overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review. The problem is in the `get_tool_call_parser_type` function in sglang_rollout.py (lines 225-246). The function is checking if `parser.bot_token.strip()` exists as a single token in the tokenizer's vocabulary, but for the gpt-oss parser type, the bot_token is `<|start|>assistant<|channel|>commentary`, which is a compound token sequence rather than a single special token. For gpt-oss models, ``` parser.bot_token.strip() = <|start|>assistant<|channel|>commentary This gets tokenized as [200006, 173781, 200005, 12606, 815] (5 tokens) ``` The check parser.bot_token.strip() in tokenizer_vocab returns False because it's looking for this entire string as a single vocabulary entry The current logic assumes that bot_token should be a single special token that exists in the vocabulary, but for GPT-OSS models, it's actually a sequence of tokens that need to be tokenized. ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test unit test offline > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) --------- Co-authored-by: Hejian Sang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent baf7506 commit d45d049

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

verl/workers/rollout/sglang_rollout/sglang_rollout.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,10 @@ def get_tool_call_parser_type(
226226
processing_class: PreTrainedTokenizer | PreTrainedTokenizerFast | ProcessorMixin,
227227
) -> str:
228228
items = FunctionCallParser.ToolCallParserEnum.items()
229+
if "gpt-oss" in getattr(processing_class, "name_or_path", "").lower():
230+
logger.debug(f"gpt-oss model detected from name_or_path: {processing_class.name_or_path}")
231+
logger.debug("Using 'gpt-oss' tool call parser.")
232+
return "gpt-oss"
229233
for parser_type, parser_cls in items:
230234
parser = parser_cls()
231235
try:

0 commit comments

Comments
 (0)