Skip to content

Commit 54c204a

Browse files
vermouth1992techkang
authored andcommitted
[ci] fix: fix more ci by pin transformers version (#3582)
### What does this PR do? - As title ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent f9584fb commit 54c204a

File tree

4 files changed

+52
-6
lines changed

4 files changed

+52
-6
lines changed

.github/workflows/e2e_eval_aime24.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124
- name: Install the current repository
125125
run: |
126126
pip3 install --no-deps -e .[test,gpu,math]
127-
pip3 install math-verify
127+
pip3 install math-verify transformers==4.56.2
128128
- name: Prepare aime24 dataset
129129
run: |
130130
ray stop --force

.github/workflows/e2e_ppo_trainer_megatron_vllm.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ permissions:
8787
env:
8888
IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:app-verl0.5-transformers4.55.4-vllm0.10.0-mcore0.13.0-te2.2"
8989
DYNAMIC_RUNNER_ENDPOINT: "https://sd10g3clalm04ug7alq90.apigateway-cn-beijing.volceapi.com/runner"
90+
TRANSFORMERS_VERSION: "4.56.2"
9091

9192
jobs:
9293
setup:
@@ -121,6 +122,7 @@ jobs:
121122
- name: Install the current repository
122123
run: |
123124
pip3 install --no-deps -e .[test]
125+
pip3 install math-verify transformers==$TRANSFORMERS_VERSION
124126
- name: Prepare GSM8K dataset
125127
run: |
126128
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
@@ -173,6 +175,7 @@ jobs:
173175
- name: Install the current repository
174176
run: |
175177
pip3 install --no-deps -e .[test]
178+
pip3 install math-verify transformers==$TRANSFORMERS_VERSION
176179
- name: Prepare GSM8K dataset
177180
run: |
178181
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
@@ -210,6 +213,7 @@ jobs:
210213
- name: Install the current repository
211214
run: |
212215
pip3 install --no-deps -e .[test]
216+
pip3 install math-verify transformers==$TRANSFORMERS_VERSION
213217
- name: Prepare GSM8K dataset
214218
run: |
215219
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
@@ -241,6 +245,7 @@ jobs:
241245
- name: Install the current repository
242246
run: |
243247
pip3 install --no-deps -e .[test]
248+
pip3 install math-verify transformers==$TRANSFORMERS_VERSION
244249
- name: Prepare GSM8K dataset
245250
run: |
246251
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k

.github/workflows/e2e_ppo_trainer_megatron_vllm_2.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ permissions:
8787
env:
8888
IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:app-verl0.5-transformers4.55.4-vllm0.10.0-mcore0.13.0-te2.2"
8989
DYNAMIC_RUNNER_ENDPOINT: "https://sd10g3clalm04ug7alq90.apigateway-cn-beijing.volceapi.com/runner"
90+
TRANSFORMERS_VERSION: "4.56.2"
9091

9192
jobs:
9293
setup:
@@ -121,6 +122,7 @@ jobs:
121122
- name: Install the current repository
122123
run: |
123124
pip3 install --no-deps -e .[test]
125+
pip3 install transformers==$TRANSFORMERS_VERSION
124126
- name: Prepare GSM8K dataset
125127
run: |
126128
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
@@ -154,6 +156,7 @@ jobs:
154156
run: |
155157
pip3 install --no-deps -e .[test]
156158
pip3 install mbridge
159+
pip3 install transformers==$TRANSFORMERS_VERSION
157160
- name: Prepare GSM8K dataset
158161
run: |
159162
python3 examples/data_preprocess/gsm8k.py --local_dataset_path ${HOME}/models/hf_data/gsm8k
@@ -186,6 +189,7 @@ jobs:
186189
- name: Install the current repository
187190
run: |
188191
pip3 install --no-deps -e .[test]
192+
pip3 install transformers==$TRANSFORMERS_VERSION
189193
- name: Prepare Geo3k dataset
190194
run: |
191195
python3 examples/data_preprocess/geo3k.py --local_dataset_path ${HOME}/models/hf_data/hiyouga/geometry3k/
@@ -220,6 +224,7 @@ jobs:
220224
- name: Install the current repository
221225
run: |
222226
pip3 install --no-deps -e .[test,vllm]
227+
pip3 install transformers==$TRANSFORMERS_VERSION
223228
- name: Prepare GSM8K dataset
224229
run: |
225230
ray stop --force
@@ -359,7 +364,7 @@ jobs:
359364
- name: Install the current repository
360365
run: |
361366
pip3 install --no-deps -e .[test,gpu,vllm,geo,trl]
362-
pip install "transformers[hf_xet]==4.54.0"
367+
pip3 install transformers==$TRANSFORMERS_VERSION
363368
# Geo3k
364369
- name: Prepare GEO3K dataset
365370
run: |

.github/workflows/reward_model.yml

Lines changed: 40 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,32 @@ concurrency:
5858
group: ${{ github.workflow }}-${{ github.ref }}
5959
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
6060

61+
62+
env:
63+
IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:app-verl0.5-transformers4.55.4-sglang0.4.10.post2-mcore0.13.0-te2.2"
64+
DYNAMIC_RUNNER_ENDPOINT: "https://sd10g3clalm04ug7alq90.apigateway-cn-beijing.volceapi.com/runner"
65+
TRANSFORMERS_VERSION: "4.56.2"
66+
67+
6168
jobs:
69+
setup:
70+
if: github.repository_owner == 'volcengine'
71+
runs-on: ubuntu-latest
72+
outputs:
73+
runner-label: ${{ steps.create-runner.outputs.runner-label }}
74+
mlp-task-id: ${{ steps.create-runner.outputs.mlp-task-id }}
75+
steps:
76+
- uses: actions/checkout@v4
77+
- id: create-runner
78+
uses: volcengine/vemlp-github-runner@v1
79+
with:
80+
mode: "create"
81+
faas-url: "${{ env.DYNAMIC_RUNNER_ENDPOINT }}"
82+
mlp-image: "${{ env.IMAGE }}"
83+
6284
reward_model:
63-
runs-on: [L20x8]
85+
needs: setup
86+
runs-on: [ "${{ needs.setup.outputs.runner-label || 'L20x8' }}" ]
6487
timeout-minutes: 20 # Increase this timeout value as needed
6588
env:
6689
HTTP_PROXY: ${{ secrets.PROXY_HTTP }}
@@ -71,9 +94,6 @@ jobs:
7194
SGL_DISABLE_TP_MEMORY_INBALANCE_CHECK: "True"
7295
NCCL_SHM_DISABLE: "1"
7396
NCCL_P2P_DISABLE: "1"
74-
container:
75-
image: verlai/verl:app-verl0.5-transformers4.55.4-sglang0.4.10.post2-mcore0.13.0-te2.2
76-
options: --gpus all --shm-size=10g
7797
steps:
7898
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
7999
with:
@@ -93,3 +113,19 @@ jobs:
93113
run: |
94114
unset http_proxy https_proxy HTTP_PROXY HTTPS_PROXY
95115
pytest -s -x tests/workers/reward_model/test_generative_reward_model.py
116+
117+
cleanup:
118+
runs-on: ubuntu-latest
119+
needs:
120+
[
121+
setup,
122+
reward_model
123+
]
124+
if: always()
125+
steps:
126+
- id: destroy-runner
127+
uses: volcengine/vemlp-github-runner@v1
128+
with:
129+
mode: "destroy"
130+
faas-url: "${{ env.DYNAMIC_RUNNER_ENDPOINT }}"
131+
mlp-task-id: "${{ needs.setup.outputs.mlp-task-id }}"

0 commit comments

Comments
 (0)