Skip to content

Commit 1df03f3

Browse files
authored
[ci] fix: release ascend test time, fix one step off-policy CI (#2731)
### What does this PR do? release ascend test time, recent PRs got cancelled but operation successfully, fix one step off-policy CI. ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent a0248a8 commit 1df03f3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/e2e_ascend.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
test:
7373
name: verl Ascend test (self-host)
7474
runs-on: [self-hosted, npu-0]
75-
timeout-minutes: 30 # Increase this timeout value as needed
75+
timeout-minutes: 40 # Increase this timeout value as needed
7676
container:
7777
image: crispig/verl_npu:cann8.1rc1-py3.10-torch2.5.1-vllm-ascend0.7.3.post1-250616
7878
volumes:

tests/special_e2e/run_one_step_off_policy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ common_params=(
7373
actor_rollout_ref.actor.clip_ratio_high=${clip_ratio_high}
7474
actor_rollout_ref.actor.clip_ratio_c=10.0
7575
actor_rollout_ref.model.path="${MODEL_PATH}"
76-
actor_rollout_ref.model.enable_gradient_checkpointing=True
7776
actor_rollout_ref.actor.optim.lr=1e-6
7877
actor_rollout_ref.actor.optim.lr_warmup_steps=-1
7978
actor_rollout_ref.actor.optim.weight_decay=0.1
@@ -127,6 +126,7 @@ if [ "${ACTOR_STRATEGY}" == "fsdp2" ]; then
127126
critic.strategy=fsdp2 \
128127
actor_rollout_ref.actor.grad_clip=1.0 \
129128
actor_rollout_ref.model.use_remove_padding=True \
129+
actor_rollout_ref.model.enable_gradient_checkpointing=True \
130130
actor_rollout_ref.actor.use_dynamic_bsz=True \
131131
actor_rollout_ref.ref.log_prob_use_dynamic_bsz=True \
132132
actor_rollout_ref.rollout.log_prob_use_dynamic_bsz=True \

0 commit comments

Comments
 (0)