Skip to content

Conversation

@vnadathur
Copy link
Contributor

@vnadathur vnadathur commented Oct 10, 2025

This is outdated, I messed up src control. Here is the updated pr: #28368

I track in this issue: #26567

open up the opportunity for MLA to its own custom op instead of unified_attention allowing for to potentially explore passing q_nope and q_rope independently instead of concatenated

Reference: #24620 and #25103

The buildthedocs fails because of the changes in flashmla_sparse.py. This will prob need to be overwritten.

cc @ProExpertProg @MatthewBonanni @LucasWilkinson

@vnadathur vnadathur marked this pull request as ready for review October 10, 2025 06:46
@mergify mergify bot added the v1 label Oct 10, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@mergify
Copy link

mergify bot commented Oct 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @vnadathur.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@ProExpertProg ProExpertProg linked an issue Oct 30, 2025 that may be closed by this pull request
Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split the tuple and update flashmla_sparse to the new interface as well! Also cc @MatthewBonanni and @LucasWilkinson - do we expect a win here somewhere because q no longer needs to be concatenated?

@mergify
Copy link

mergify bot commented Nov 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @vnadathur.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@vnadathur vnadathur requested a review from gshtras as a code owner November 9, 2025 20:16
@mergify mergify bot added the rocm Related to AMD ROCm label Nov 9, 2025
@vnadathur vnadathur closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocm Related to AMD ROCm v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor][MLA]: Independently pass q_nope & q_rope

2 participants