-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Refactor][MLA]: Independently passing q_nope & q_rope #26568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
This pull request has merge conflicts that must be resolved before it can be |
ProExpertProg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split the tuple and update flashmla_sparse to the new interface as well! Also cc @MatthewBonanni and @LucasWilkinson - do we expect a win here somewhere because q no longer needs to be concatenated?
|
This pull request has merge conflicts that must be resolved before it can be |
This is outdated, I messed up src control. Here is the updated pr: #28368
I track in this issue: #26567
Reference: #24620 and #25103
The buildthedocs fails because of the changes in flashmla_sparse.py. This will prob need to be overwritten.
cc @ProExpertProg @MatthewBonanni @LucasWilkinson