Skip to content

Conversation

@liangfu
Copy link
Contributor

@liangfu liangfu commented Mar 12, 2025

This PR include two changes:

  • Split the test scripts into 1_core and 2-core test folders
  • Refactored test_contexted_kv_attention to flatten the nested parameterization (3 loops → 1 list) while expanding coverage variety. The change reduces test combinations from 64 to 10 carefully selected cases, achieving ~80% CI time reduction. The new test suite covers 2x more parameter ranges - from minimal (1-8 heads) through common (16-32 heads) to large scale (48-64 heads), including edge cases with 1-199 batch sizes. Both precision modes are verified across all scales. All test cases pass with both standard and mixed precision modes.

Related PR: #13245 #14085

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 12, 2025
Signed-off-by: Liangfu Chen <[email protected]>
@liangfu liangfu force-pushed the flatten-test-param-1 branch from cb619b8 to 4944f3e Compare March 13, 2025 19:23
Copy link
Contributor

@lingfanyu lingfanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aws-satyajith aws-satyajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this change!

@simon-mo simon-mo merged commit d3d4956 into vllm-project:main Mar 14, 2025
17 of 19 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants