Skip to content

Conversation

@joerunde
Copy link
Collaborator

@joerunde joerunde commented Mar 12, 2025

Quick fix for a small bug with the log introduced in #14466

That warning log always prints, since we actually configure the v1 scheduler as a string. 🤦

This change instead checks the resolved class, using an equality check against the existing V1 scheduler class. I did it this way, instead of isinstance(scheduler, V1Scheduler), since existing scheduler classes may inherit from the V1 scheduler and we still want to print the warning if that's the case.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 12, 2025
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 12, 2025
Signed-off-by: Joe Runde <[email protected]>
@comaniac comaniac enabled auto-merge (squash) March 12, 2025 22:02
@vllm-bot vllm-bot merged commit 165290d into vllm-project:main Mar 13, 2025
28 of 30 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-merge ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants