[bugfix] fixup warning message for plugged schedulers for v1 #14700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for a small bug with the log introduced in #14466
That warning log always prints, since we actually configure the v1 scheduler as a string. 🤦
This change instead checks the resolved class, using an equality check against the existing V1 scheduler class. I did it this way, instead of
isinstance(scheduler, V1Scheduler), since existing scheduler classes may inherit from the V1 scheduler and we still want to print the warning if that's the case.