From 9fecdcde65880dd466f5d2a3f9e45422397c6cdf Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Sat, 8 Mar 2025 16:16:40 +0000 Subject: [PATCH 1/2] Updated CODEOWNERS for structured output Add myself to the structured output paths. Add new entries for V1 and the structured output tests. Add @mgoin to all of the new lines, as well, since he was on the existing entry for the feature. Signed-off-by: Russell Bryant --- .github/CODEOWNERS | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index bc324d8b988b..543e53caa8b3 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -10,17 +10,20 @@ /vllm/worker/worker.py @zhuohan123 @youkaichao @alexm-redhat @comaniac @njhill /vllm/model_executor/layers/sampler.py @zhuohan123 @youkaichao @alexm-redhat @comaniac @njhill /vllm/model_executor/layers/quantization @mgoin @robertgshaw2-redhat @tlrmchlsmth -/vllm/model_executor/guided_decoding @mgoin +/vllm/model_executor/guided_decoding @mgoin @russellb /vllm/multimodal @DarkLight1337 @ywang96 CMakeLists.txt @tlrmchlsmth # vLLM V1 /vllm/v1 @WoosukKwon @robertgshaw2-redhat @njhill @ywang96 @comaniac @alexm-redhat +/vllm/v1/structured_output @mgoin @russellb # Test ownership /tests/async_engine @njhill @robertgshaw2-redhat @simon-mo /tests/test_inputs.py @DarkLight1337 @ywang96 /tests/entrypoints @DarkLight1337 @robertgshaw2-redhat @simon-mo +/tests/entrypoints/llm/test_guided_generate.py @mgoin @russellb +/tests/model_executor/test_guided_processors.py @mgoin @russellb /tests/models @DarkLight1337 @ywang96 /tests/multimodal @DarkLight1337 @ywang96 /tests/prefix_caching @comaniac @KuntaiDu @@ -34,3 +37,5 @@ CMakeLists.txt @tlrmchlsmth /tests/multi_step @alexm-redhat @comaniac /tests/weight_loading @mgoin @youkaichao /tests/basic_correctness/test_chunked_prefill @rkooo567 @comaniac +/tests/v1/entrypoints/llm/test_struct_output_generate.py @mgoin @russellb +/tests/v1/structured_output @mgoin @russellb From 3a197a591e2c490f01a2c882722eedaa48dbc732 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Sat, 8 Mar 2025 16:19:22 +0000 Subject: [PATCH 2/2] Put tests in alphabetical order in CODEOWNERS Signed-off-by: Russell Bryant --- .github/CODEOWNERS | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 543e53caa8b3..860c5c6cd537 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -19,23 +19,23 @@ CMakeLists.txt @tlrmchlsmth /vllm/v1/structured_output @mgoin @russellb # Test ownership +/.buildkite/lm-eval-harness @mgoin @simon-mo /tests/async_engine @njhill @robertgshaw2-redhat @simon-mo -/tests/test_inputs.py @DarkLight1337 @ywang96 +/tests/basic_correctness/test_chunked_prefill @rkooo567 @comaniac +/tests/distributed/test_multi_node_assignment.py @youkaichao +/tests/distributed/test_pipeline_parallel.py @youkaichao +/tests/distributed/test_same_node.py @youkaichao /tests/entrypoints @DarkLight1337 @robertgshaw2-redhat @simon-mo /tests/entrypoints/llm/test_guided_generate.py @mgoin @russellb +/tests/kernels @tlrmchlsmth @WoosukKwon /tests/model_executor/test_guided_processors.py @mgoin @russellb /tests/models @DarkLight1337 @ywang96 +/tests/multi_step @alexm-redhat @comaniac /tests/multimodal @DarkLight1337 @ywang96 /tests/prefix_caching @comaniac @KuntaiDu -/tests/spec_decode @njhill @LiuXiaoxuanPKU -/tests/kernels @tlrmchlsmth @WoosukKwon /tests/quantization @mgoin @robertgshaw2-redhat -/.buildkite/lm-eval-harness @mgoin @simon-mo -/tests/distributed/test_multi_node_assignment.py @youkaichao -/tests/distributed/test_pipeline_parallel.py @youkaichao -/tests/distributed/test_same_node.py @youkaichao -/tests/multi_step @alexm-redhat @comaniac -/tests/weight_loading @mgoin @youkaichao -/tests/basic_correctness/test_chunked_prefill @rkooo567 @comaniac +/tests/spec_decode @njhill @LiuXiaoxuanPKU +/tests/test_inputs.py @DarkLight1337 @ywang96 /tests/v1/entrypoints/llm/test_struct_output_generate.py @mgoin @russellb /tests/v1/structured_output @mgoin @russellb +/tests/weight_loading @mgoin @youkaichao